Skip to content

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Feb 8, 2015

Less lines.

@laanwj
Copy link
Member

laanwj commented Feb 9, 2015

NACK. It's less lines, but less self-documenting. Semantic information as well as encapsulation is lost

@jtimon
Copy link
Contributor Author

jtimon commented Feb 10, 2015

Another argument is moving more logic out of the primitives, the same reason why @sipa didn't wanted primitives/block to depend on pow.o
But I don't have a strong opinion on this, one more nack or lack of interest for a while and I'm closing it.

@sipa
Copy link
Member

sipa commented Feb 11, 2015

@laanwj Would making a IsTxInFinal function in main be acceptable?

@jtimon
Copy link
Contributor Author

jtimon commented Feb 13, 2015

I think at that point actual documentation would be better than self-documentation.
Anyway, I'm closing. We can come back to this after isfinaltx has been moved to consensus.o

@jtimon jtimon closed this Feb 13, 2015
jtimon referenced this pull request in maaku/bitcoin May 16, 2015
…hose semantics will not survive revival of sequence numbers.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants