WIP: Encapsulate consensus and policy code #5768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtimon
force-pushed
the
consensus_policy
branch
3 times, most recently
from
b3e6835 to
359c50a
Compare
jtimon
force-pushed
the
consensus_policy
branch
2 times, most recently
from
157d3c9 to
510b892
Compare
jtimon
force-pushed
the
consensus_policy
branch
3 times, most recently
from
991b0c5 to
1bc8284
Compare
jtimon
force-pushed
the
consensus_policy
branch
2 times, most recently
from
3b337ae to
60ce783
Compare
jtimon
force-pushed
the
consensus_policy
branch
3 times, most recently
from
739b93c to
c23b686
Compare
jtimon
force-pushed
the
consensus_policy
branch
3 times, most recently
from
6e96cc6 to
860419d
Compare
…Consensus::Params)
s/Params().HashGenesisBlock()/params.hashGenesisBlock
CheckBlock, ContextualCheckBlockHeader and ContextualCheckBlock
…tandardTx(tx, reason)
…IFY_LOW_S) for signing The new ALL_SCRIPT_VERIFY_FLAGS in script/interpreter is independent from policy
…CTxMemPoolEntry has to be separated temporarily as well)
…policy::minRelayTxFee
…tly of the network
Contributor
Author
|
Closing for now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. I'm trying to isolate consensus and policy code and this is my longest branch on that.
I will open other PRs extracting subsets of this, but people interested in this work can see a unified thing here and hopefully I will e able to get some feedback.
Please don't comment on individual commits as this will be rebased very often (or do it, just be aware that your comments will probably disappear soon).
So far this contains:
*** WAIT_REVIEW MOVEONLY-ish: Preparations to not include main.h from any other header #5681 [main_includes]
*** WAIT_REVIEW Cleanup: Don't include main.h from any other header #5697 [main_includes2]
*** WAIT_REVIEW MOVEONLY: Move constants and globals to consensus.h and policy.o #5696 [consensus_policy0]
*** WAIT_REVIEW Consensus: Move CheckTransaction() from main to consensus/consensus #5669 [consensus](on main_includes)
*** WAIT_REVIEW Refactor: Create CCoinsViewEfficient interface for CCoinsViewCache #5747
*** WAIT_REVIEW Policy: Create CPolicy interface and CStandardPolicy class implementing it #5595 [policy]
*** WAIT_REVIEW Change: Refactor: inline main:GetMinRelayFee() in main:AcceptToMemoryPool() #5709 [getminrelayfee]
*** WAIT_REVIEW TRIVIAL: Refactor: inline CTxIn::IsFinal() [ only used in main::IsFinalTx() ] #5769 [isfinal]