Skip to content

Conversation

@sipa
Copy link
Member

@sipa sipa commented Feb 6, 2015

No description provided.

@sdaftuar
Copy link
Member

sdaftuar commented Feb 6, 2015

First, I tested this code using the same deployment testing script I used on #5713 (submitting ver2 and ver3 blocks, with and without properly DER encoded signatures) over the p2p network to a node running the new code, and the switchover worked as expected.

I did notice that, unlike for the implementation in 0.10, we're not bumping the block version number here. I believe the only effect of that would be that mining nodes must upgrade to 0.10 or higher in order to implement the soft-fork, is that correct? I assume that is the intent?

@sipa
Copy link
Member Author

sipa commented Feb 6, 2015

@sdaftuar Eh, no, that was not the intent. Thanks for reviewing!

I've updated the code to produce v3 blocks, and also prevented non-DERSIG from entering the mempool (which should already be impossible due to standardness rules, but belt-and-suspenders...).

@laanwj
Copy link
Member

laanwj commented Feb 9, 2015

utACK

@laanwj laanwj merged commit 3230b32 into bitcoin:0.9 Feb 13, 2015
laanwj added a commit that referenced this pull request Feb 13, 2015
3230b32 Raise version of created blocks, and enforce DERSIG in mempool (Pieter Wuille)
989d499 Backport of some of BIP66's tests (Pieter Wuille)
ab03660 Implement BIP 66 validation rules and switchover logic (Pieter Wuille)
reddink added a commit to reddink/reddcoin-3.10 that referenced this pull request Mar 3, 2016
bitcoin#5762 (bitcoin) Implement BIP 66 validation rules and switchover logic
Had been partially removed - reinstated
reddink added a commit to reddink/reddcoin-3.10 that referenced this pull request Aug 4, 2016
bitcoin#5762 (bitcoin) Implement BIP 66 validation rules and switchover logic
Had been partially removed - reinstated
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants