Introduce basic modularization #5752
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to bitcoin#3440 it would make sense to decouple the wallet and the miner (and maybe other things) from the init-/shutdown-process, etc. This is related to bitcoin#5686, bitcoin#5744, bitcoin#5745
jonasschnelli
force-pushed
the
2015/02/module_interface
branch
from
6828277 to
7bd633c
Compare
Contributor
|
Concept ACK |
Contributor
|
Seems reasonable but we shouldn't let this languish - concept ACK - but we should probably close if it won't get merged anytime soon. |
Contributor
Author
|
Agreed. I think we all agree that bitcoin-core requires modularization to allow safer code changes, detaching of the UI and Wallet, etc. Closing, and signaling willingness to work on this after we have a more clean plan what we do want to achieve in terms of modularization. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #3440 it would make sense to decouple the wallet and the miner (and maybe other things) from the init-/shutdown-process, etc.
This is related to #5686, #5744, #5745
If this gets merged, my plans are to first transform the miner into a module, then the wallet.
The goal should be to remove the
ENABLE_WALLETifdefs and make use of the modular concept.If this looks to useless, i can transform the internal miner into a module within this PR (but it will be a harder review).