Add more information to errors in ReadBlockFromDisk #5710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm trying to trigger this code path on the system I have that produces this error during normal operation without fault injection. |
Contributor
|
utACK |
A lot of times, disk corruption problems appear here. To facilitate debugging and troubleshooting, add position information to the error messages.
laanwj
force-pushed
the
2015_01_block_corrupt_debug
branch
from
69cda08 to
f5791c6
Compare
Member
|
utACK |
Contributor
|
I ran this for several days without problem on a machine that once had bitcoind die on ReadBlockFromDisk. (Alas, I couldn't reproduce the previous error even with a full reindex.) I did not inject errors to test the code paths. |
sipa
added a commit
that referenced
this pull request
Feb 16, 2015
f5791c6 Add more information to errors in ReadBlockFromDisk (Wladimir J. van der Laan)
Contributor
|
Oops forgot to mention. I tested this on a system which had repeatable ReadBlockFromDisk issues and this worked correctly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of times, disk corruption problems appear here.
To facilitate debugging and troubleshooting, add position information to the error messages.
I've tested all the error messages by injecting errors.