Skip to content

Conversation

@sipa
Copy link
Member

@sipa sipa commented Jan 25, 2015

No description provided.

@Michagogo
Copy link
Contributor

A few nits:

  • There's some inconsistency between "implemented since" and "in". I feel like the latter sounds more natural, but either way it should be consistent.
  • Not sure I completely understand the logic behind the use of bold and italics, but maybe that's just me
  • I don't think it's necessary to mention rc versions -- they're a technicality of the release process, I think they can just be listed as v0.10.0.
  • Was 0.9 still called Bitcoin-Qt? I thought we were calling it Bitcoin Core GUI (or just "the GUI") now.

Other than that, as far as I can tell, looks good. ACK.

@laanwj laanwj added the Docs label Jan 26, 2015
@laanwj
Copy link
Member

laanwj commented Jan 26, 2015

Nice idea!

  • May make sense to add commit IDs or pull #'s, if we know them
  • Maybe format as a table

Not meant as blockers or necessarily have to be done in this pull, ACK anyhow.

@fanquake
Copy link
Member

fanquake commented Feb 2, 2015

ACK

@fanquake
Copy link
Member

fanquake commented Feb 2, 2015

@laanwj Just to follow up:
Implemented
BIPS 11,12,13 #669
BIP 14 #707
BIP 16 #748
BIP 22 #936
BIP 23 #1816
BIP 31 #1081
BIP 34 #1526
BIP 35 #1641
BIP 37 #1795
BIP 42 #3842
BIP 61 #3185
BIP 70 #2539
BIP 71 #5216

Open Pull Request
BIP 66 #5713

@laanwj
Copy link
Member

laanwj commented Feb 2, 2015

@fanquake Whoa, thanks, nice work of archeology tracking those down.

@sipa
Copy link
Member Author

sipa commented Feb 5, 2015

Updated, added BIP66, included @fanquake's list, and added PR numbers for BIP21 and BIP30.

@Michagogo
Copy link
Contributor

@sipa Do you mean @fanquake?

On Thursday, February 5, 2015, Pieter Wuille [email protected]
wrote:

Updated, added BIP66, included @Michagogo https://github.com/Michagogo's
list, and added PR numbers for BIP21 and BIP30.


Reply to this email directly or view it on GitHub
#5708 (comment).

@Michagogo
Copy link
Contributor

And ICYMI, #5708 (comment)

@sipa
Copy link
Member Author

sipa commented Feb 16, 2015

Updated.

@gmaxwell
Copy link
Contributor

ACK.

@laanwj laanwj merged commit b63ae56 into bitcoin:master Feb 23, 2015
laanwj added a commit that referenced this pull request Feb 23, 2015
b63ae56 Add list of implemented BIPs (Pieter Wuille)
@siobh9
Copy link

siobh9 commented Apr 21, 2018

Would it be possible to update this with changes that happened after such as 2e17ac8#diff-dedcc88d0e66b86a19981e7c175658c2 that changed the BIP 11 implementation here: 7e55c1a#diff-dedcc88d0e66b86a19981e7c175658c2 . I am currently porting BIPs into a project and this would make it much easier to avoid including a deprecated addition.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants