fix crash: CoinControl "space" bug #5700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Recreated the bug, and the provided patch does indeed fix the behaviour. ACK |
Contributor
Member
|
Thanks, good catch |
laanwj
added a commit
that referenced
this pull request
Jan 23, 2015
0eade74 fix crash: CoinControl "space" bug (fsb4000)
laanwj
pushed a commit
that referenced
this pull request
Jan 23, 2015
Just like novacoin-project/novacoin@baf80c2 Github-Pull: #5700 Rebased-From: 944c256
jyap808
added a commit
to jyap808/jumbucks
that referenced
this pull request
Sep 14, 2015
This is a port of the pull bitcoin/bitcoin#5700 made by fsb4000 for Bitcoin Core to fix the crash problem: CoinControl "space" bug.
sigmike
pushed a commit
to sigmike/peercoin
that referenced
this pull request
Jun 17, 2017
This is a port of the pull bitcoin/bitcoin#5700 made by fsb4000 for Bitcoin Core to fix the crash problem: CoinControl "space" bug.
aistrych
added a commit
to aistrych/Pink2
that referenced
this pull request
Dec 18, 2018
aistrych
added a commit
to aistrych/Pink2
that referenced
this pull request
Jan 16, 2019
reddink
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
May 27, 2020
Just like novacoin-project/novacoin@baf80c2 Github-Pull: bitcoin#5700 Rebased-From: 944c256 (cherry picked from commit ed4206a)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description:
Fix:
this->currentItem() returns the current item in the tree widget and NULL if no selected items.
So we don't try setCheckState for NULL.
As
novacoin-project/novacoin@baf80c2
novacoin-project/novacoin#120