Skip to content

Conversation

@theuni
Copy link
Member

@theuni theuni commented Jan 20, 2015

As discussed recently in several other PRs.

This bumps the build SDK to 10.9. I would bump to 10.10, but our current clang has problems there, and I suspect that will eventually fix itself when we bump to a newer build distro for gitian/travis. The 10.10 bump can come at that point.

This also bumps the minimum requirement to 10.7, leaving 10.6 no longer supported. This is in line with what other applications are doing these days as well. 10.7 is the first version that no longer supports x86 (x86_64 only), as well as supporting libc++, leaving that as an option for us in the near future.

Tested locally and via Gitian with no problems. All font/unicode issues are resolved as expected.

This also bumps the version used for Travis builds, so this PR itself will build against 10.9.

@fanquake
Copy link
Member

Concept ACK ACK ACK

@laanwj
Copy link
Member

laanwj commented Jan 20, 2015

Nice! I'm surprised how few changes are necessary.

utACK

@jonasschnelli
Copy link
Contributor

Tested ACK (review, gitian build).
Prebuilt binaries: https://bitcoin.jonasschnelli.ch/pulls/5684/

Chinese looks also good (osx 10.10 retina):
bildschirmfoto 2015-01-20 um 11 14 55

@laanwj laanwj merged commit f0172bf into bitcoin:master Jan 20, 2015
laanwj added a commit that referenced this pull request Jan 20, 2015
f0172bf osx: bump build sdk to 10.9 (Cory Fields)
@laanwj
Copy link
Member

laanwj commented Jan 20, 2015

Thanks for testing @jonasschnelli , going to merge this right away to make sure this is used by travis and gitian.

@theuni
Copy link
Member Author

theuni commented Jan 20, 2015

@laanwj The work happened in #5582, this was just pulling the trigger.

Thinking on this a little more, we should document pretty loudly that 10.6 will not be supported for 0.11. It'd be helpful to add to the 0.10 release notes something like : "OSX 10.6 support is deprecated and will be completely removed in 0.11."

I'll also add a change so that configure fails if building against <10.7.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants