Get rid of DetectShutdownThread #5679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main thread spends time waiting for the DetectShutdownThread. So why not just run this waiting loop function in the main thread? One thread-stack less saves 4MB of virtual memory on 32-bit, and 8MB on 64-bit.
Contributor
|
ACK |
laanwj
added a commit
that referenced
this pull request
Feb 9, 2015
28ee7e8 Get rid of DetectShutdownThread (Wladimir J. van der Laan)
maflcko
pushed a commit
that referenced
this pull request
Apr 15, 2020
808ef36 [doc] Update thread information in developer docs (John Newbery) Pull request description: - DumpAddresses thread was removed in #5964 - Shutdown thread was removed in #5679 - Add new threads (scheduler, RPC worker, indexer, tor control) - Small changes to documentation of other threads ACKs for top commit: MarcoFalke: ACK 808ef36 hebasto: ACK 808ef36. Tree-SHA512: 85b6ace7bcc4dee030c63461bef1ded1a9581d4fa249c59f6fcd5d33d89c4357a6b8b35888ce0960f276d397b5e38a21e6c5d4b7b79544827a28c950e097b36d
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 16, 2020
808ef36 [doc] Update thread information in developer docs (John Newbery) Pull request description: - DumpAddresses thread was removed in bitcoin#5964 - Shutdown thread was removed in bitcoin#5679 - Add new threads (scheduler, RPC worker, indexer, tor control) - Small changes to documentation of other threads ACKs for top commit: MarcoFalke: ACK 808ef36 hebasto: ACK 808ef36. Tree-SHA512: 85b6ace7bcc4dee030c63461bef1ded1a9581d4fa249c59f6fcd5d33d89c4357a6b8b35888ce0960f276d397b5e38a21e6c5d4b7b79544827a28c950e097b36d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thread spends time waiting for the DetectShutdownThread. So why not just run this waiting loop function in the main thread?
One thread-stack less saves 4MB of virtual memory on 32-bit, and 8MB on 64-bit.