Skip to content

Conversation

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Jan 12, 2015

Fixes #5625

@jonasschnelli
Copy link
Contributor

@zander please have a look at: #5625. I think the problem addresses in the PR is win only.

@zander
Copy link

zander commented Jan 13, 2015

I suggest using #ifdef Q_OS_WIN then for this code; so it won't make things worse on other OS's (esp linux) where this behavior change is not wanted.

@jonasschnelli
Copy link
Contributor

@zander in general we like to keep the platform dependent stuff (#ifdef) on a minimum. And the problem with mixed colors could occur on other platforms.

@jonasschnelli
Copy link
Contributor

Tested on Win,OSX,Ubuntu (change only visible on Windows, see below).

Tested ACK.
But it brought me to a new issue: #5653
bildschirmfoto 2015-01-13 um 08 28 43

@laanwj laanwj added the GUI label Jan 13, 2015
@zander
Copy link

zander commented Jan 13, 2015

And the problem with mixed colors could occur on other platforms.

The "problem" is debatable. Having the same icon in all places is quite important for a stable UI (consistency).
Anywhere I look having monochrome icons that follow the text color just isn't the default, and the menu in the latest screenshot looks broken. Its completely inconsistent with all the other apps because they all use color icons. Its also inconsistent with itself because the "Show / Hide" for instance is not actually the logo you see in the taskbar, its got a different color.

Bottom line, I have zero apps on either Windows (8.1) nor on KDE that have monochrome icons in their systray context menu. So this just doesn't look consistent in any way at all.

@jonasschnelli
Copy link
Contributor

@zander The discussion over the monochrome icons has already been held. But feel free to contribute over issue and new pull requests. This pull requests focus on #5625.

@laanwj
Copy link
Member

laanwj commented Jan 14, 2015

ACK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These extra fields neeed to be zeroed in the constructor

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createActions, which is part of the constructor, initialises them. Regardless, I added the (unnecessary) zeroing as requested.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's mostly to satisfy static checkers, as well as a belt-and-suspenders measure in general. Thanks.

@luke-jr luke-jr force-pushed the systray_text_icons branch from 6ddd105 to 301cd2a Compare January 14, 2015 17:01
@laanwj laanwj merged commit 301cd2a into bitcoin:master Jan 14, 2015
laanwj added a commit that referenced this pull request Jan 14, 2015
301cd2a Use text-color icons for system tray Send/Receive menu entries (Luke Dashjr)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QT] Win: icon coloring issue tray-menu

4 participants