-
Notifications
You must be signed in to change notification settings - Fork 38.8k
Use text-color icons for system tray Send/Receive menu entries #5649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I suggest using #ifdef Q_OS_WIN then for this code; so it won't make things worse on other OS's (esp linux) where this behavior change is not wanted. |
|
@zander in general we like to keep the platform dependent stuff (#ifdef) on a minimum. And the problem with mixed colors could occur on other platforms. |
|
Tested on Win,OSX,Ubuntu (change only visible on Windows, see below). Tested ACK. |
The "problem" is debatable. Having the same icon in all places is quite important for a stable UI (consistency). Bottom line, I have zero apps on either Windows (8.1) nor on KDE that have monochrome icons in their systray context menu. So this just doesn't look consistent in any way at all. |
|
ACK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These extra fields neeed to be zeroed in the constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createActions, which is part of the constructor, initialises them. Regardless, I added the (unnecessary) zeroing as requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's mostly to satisfy static checkers, as well as a belt-and-suspenders measure in general. Thanks.
6ddd105 to
301cd2a
Compare
301cd2a Use text-color icons for system tray Send/Receive menu entries (Luke Dashjr)

Fixes #5625