Improve robustness of DER recoding code #5640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Untested ACK |
Contributor
|
ACK |
laanwj
force-pushed
the
2015_01_openssl_robustness
branch
from
849e6c7 to
7c58da9
Compare
Add some defensive programming on top of bitcoin#5634. This copies the respective OpenSSL code in ECDSA_verify in OpenSSL pre-1.0.1k (e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_1j/crypto/ecdsa/ecs_vrf.c#L89) more closely. As reported by @SergioDemianLerner.
laanwj
force-pushed
the
2015_01_openssl_robustness
branch
from
7c58da9 to
c6b7b29
Compare
Member
Author
|
Added a comment |
laanwj
added a commit
that referenced
this pull request
Jan 12, 2015
c6b7b29 Improve robustness of DER recoding code (Wladimir J. van der Laan)
laanwj
added a commit
that referenced
this pull request
Jan 12, 2015
Add some defensive programming on top of #5634. This copies the respective OpenSSL code in ECDSA_verify in OpenSSL pre-1.0.1k (e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_1j/crypto/ecdsa/ecs_vrf.c#L89) more closely. As reported by @SergioDemianLerner. Github-Pull: #5640 Rebased-From: c6b7b29
laanwj
added a commit
that referenced
this pull request
Jan 12, 2015
Add some defensive programming on top of #5634. This copies the respective OpenSSL code in ECDSA_verify in OpenSSL pre-1.0.1k (e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_1j/crypto/ecdsa/ecs_vrf.c#L89) more closely. As reported by @SergioDemianLerner. Github-Pull: #5640 Rebased-From: c6b7b29
laanwj
added a commit
that referenced
this pull request
Jan 12, 2015
Add some defensive programming on top of #5634. This copies the respective OpenSSL code in ECDSA_verify in OpenSSL pre-1.0.1k (e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_1j/crypto/ecdsa/ecs_vrf.c#L89) more closely. As reported by @SergioDemianLerner. Github-Pull: #5640 Rebased-From: c6b7b29
wtogami
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jan 13, 2015
Add some defensive programming on top of bitcoin#5634. This copies the respective OpenSSL code in ECDSA_verify in OpenSSL pre-1.0.1k (e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_1j/crypto/ecdsa/ecs_vrf.c#L89) more closely. As reported by @SergioDemianLerner. Bitcoin Github-Pull: bitcoin#5640 Rebased-From: c6b7b29
Gitju
pushed a commit
to machinecoin-project/machinecoin-core
that referenced
this pull request
Jan 15, 2015
This copies the respective OpenSSL code in ECDSA_verify in OpenSSL pre-1.0.1k (e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_1j/crypto/ecdsa/ecs_vrf.c#L89) more closely. As reported by @SergioDemianLerner. (by laanwj bitcoin/bitcoin#5640)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some defensive programming on top of #5634.
This copies the respective OpenSSL code in ECDSA_verify in OpenSSL pre-1.0.1k (e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_1j/crypto/ecdsa/ecs_vrf.c#L89) more closely.
As reported by @SergioDemianLerner.