Will look like:

win:

osx:

On OS X 10.10, Retina:
STATUS_COLUMN_WIDTH = 30:

STATUS_COLUMN_WIDTH = 40:

@paveljanik as mentioned on IRC: please don't use Qt4 anymore for OSX builds. It doesn't support retina.

We even should drop Qt4 compatibility for OS X because it will end up with large icons as shown above.

A warning at the end of configure would be appropriate, but breaking it for no reason would just be annoying IMO. Some users probably don't have Retina, and wouldn't benefit from updating Qt.

@luke-jr even non retina mac and older mac could run Qt5 binaries. With Qt5 the oversized icon would also render nice on non-retina.
Deprecated-unsupported warning is fine for me.

@paveljanik could you retest this with Qt5 already?

Regarding sizes: please see #5489

@zander Transparent space in icons make icons look more uniform when displayed together without clustering the code with some magic padding numbers. And potential replacement would also be more complicated with static padding in the code.

Transparent space in icons make icons look more uniform when displayed together

Definitely!

without clustering the code with some magic padding numbers.
And potential replacement would also be more complicated with static padding in the code.

Don't use static padding, just Qt::AlignmentCenter

Regarding sizing; you should really run optimize on the images before you merge, so you don't end up changing it twice. Git will keep all versions on everyones harddrive forever. Best to avoid unneeded changes. 15Kb vs 700 bytes is two orders of magnitude...

Don't use static padding, just Qt::AlignmentCenter

But this would not solve uniforming sized between icons.

Regarding sizing; you should really run optimize on the images before you merge, so you don't end up changing it twice. Git will keep all versions on everyones harddrive forever. Best to avoid unneeded changes. 15Kb vs 700 bytes is two orders of magnitude...

Yes. But this time we encountered the size issue after the merging of some new icons. That's why we have now #5489 with a included script so we might run it next time before creating a PR or merge.

Yes. But this time we encountered the size issue after the merging of some new icons. That's why we have now #5489 with a included script so we might run it next time before creating a PR or merge.

You say "yes", but I don't see a new push, so you really meant "no", didn't you?

Why don't you update this merge with the fixed icons?

@zander Because #5489 is already open and has discussion and is not finished yet.

optimized the two pngs in this pull according to #5489.

Needs rebase

Rebased.

Tested ACK OSX 10.9 with Qt5

This makes the status column too wide here (Ubuntu Qt5). This is not really a problem, but looks asymmetric, because the column is not centered.

@laanwj My ubuntu 14.04 gives out a more or less centered column.

will try now to center the content in the column.

Centering the QIcon within the QTableWidgetCell would need a custom class with a QPainter (see http://qt-project.org/forums/viewthread/31839). Just setting the alignment did not work.

I don't think it's worth doing this.

Blegh.
Can we make the width adaptive somehow? I don't understand why it shows narrower wider here.

@laanwj:
Currently i'm not investigating the width issue.
This pull make sense because the current master looks like this on windows:

But it's weird isn't it? The image has a fixed width in pixels. We set a fixed width in pixels for the column. How can this differ so much per OS or seemingly even per theme :/