[RPC] fundrawtransaction #5503

jonasschnelli · 2014-12-17T21:22:43Z

Basic implementation of a new rpc call fundrawtransaction.
This call will fill a rawtransaction containing only vouts with unspent coins from the wallet.

Currently there is no way to return the CReserveKey to the keypool.

jonasschnelli · 2014-12-17T21:26:07Z

As createrawtransactions with potential unspent vins, this call does not lock the coins somehow.

aalness · 2014-12-18T09:53:39Z

src/rpcrawtransaction.cpp

s/exiting/existing

aalness · 2014-12-18T18:31:29Z

ACK the idea. It seems useful.

gmaxwell · 2014-12-18T19:25:05Z

Sweet. This should have a mechenism to also include watchonly coins.

gmaxwell · 2014-12-18T19:33:18Z

It should support existing VINs, which are useful if you want to specifically spend a particular coin, but need more inputs to complete the txn. One reason you may want to do this is to achieve mutual exclusion with a prior transaction. If the existing vins are adequate it shouldn't add any more.

kanzure · 2014-12-19T21:39:53Z

Also, not to pile on too much, but a "fundmany" would be neat as well (in addition to watchonly support in fundrawtransaction). This would be useful for batch coin selection, offline signing, and coinjoin. Plus, fundmany is not a huge jump from sendmany.

Also, gmaxwell proposed on IRC a limit=N parameter on fundrawtransaction?

kanzure · 2014-12-20T20:35:55Z

Nevermind about fundmany: http://bitcoinstats.com/irc/bitcoin-dev/logs/2014/12/19#l1419025192

jonasschnelli · 2014-12-20T21:07:54Z

Added support for existing VINs.
Now comes with an extensive test-script.

@gmaxwell the proposed limit parameter needs probably some brainwork first. See (http://bitcoinstats.com/irc/bitcoin-dev/logs/2014/12/20#l1419085131). Maybe another pull.

jonasschnelli · 2014-12-22T08:25:44Z

Just fixed an issue in CreateTransaction which produced endless recursive loops. Travis should now be happy.

Support watchonly in fundrawtransaction, CreateTransaction, SelectCoins and coin selection in general. Coin selection is exposed over RPC through fundrawtransaction, and watchonly can be enabled by passing includeWatching true (defaults to false). fundrawtransaction will first attempt to fund a transaction without using watchonly, even when includeWatching is enabled. When this fails, an includeWatching attempt is made. When an includeWatching attempt at coin selection is performed (in CreateTransaction), and all watchonlys are consumed leaving no funds available for a fee, then CreateTransaction will not include a fee in the transaction. Also, includeWatching tests (for fundrawtransaction). See also: bitcoin#5503

fanquake · 2014-12-27T13:10:34Z

src/wallet.cpp

s/temporary/temporarily

Thanks. Fixed.

laanwj · 2015-02-27T13:37:55Z

needs rebase (assigned 0.11 milestone, would be nice to have this)

jonasschnelli · 2015-04-16T07:55:57Z

rebased.

Moved RPC function "fundrawtransaction()" from rpcrawtransaction.cpp to rpcwallet.cpp (fundrawtransaction is a wallet function). Added wallet-is-presence check because we recently removed "reqWallet" check over the RPC dispatch table.

…erage)

- fix typo - fix RPCTypeCheck for fundrawtransaction - some comments - merged with subtractFeeFromAmout patch (non trivial)

- serialize transaction size calculation (aka dummy-signing) without the need of signing the transaction (wallet can be locked to use fundrawtransaction) - rename VINS to vInputs

fundrawtransaction requires a wallet and therefore it belongs to rpcwallet.cpp

rpc dispatch tables reqWallet has been removed.

jonasschnelli · 2015-04-21T18:25:43Z

rebased.

TheBlueMatt · 2015-04-24T00:50:19Z

I needed to use this for something and rewrote/tweaked a few chunks. See changes at https://github.com/TheBlueMatt/bitcoin/tree/frt

# Conflicts: # src/rpcserver.cpp

jonasschnelli · 2015-04-24T09:12:13Z

Pulled in some commits from @TheBlueMatt. Only pulled in clear beneficial and easy reviewable commits. Other things (CCoinControl usage, watch-only support) may be better handled in a 2nd pull request to avoid large changeset.

# Conflicts: # src/wallet/rpcwallet.cpp

TheBlueMatt · 2015-04-24T09:30:28Z

@jonasschnelli Actually, the changes I made were mostly to limit the size of this pull request. Some of them look like it would become a big pull request, but once squashed, the total size is actually smaller than the original :)

TheBlueMatt · 2015-04-24T09:31:31Z

Also, not sure when you pulled in, but I force pushe'd a few times, you may want to check that the ones you merged are the latest versions (I'm done now, I think). I also merged in a tweaked-up version of fundrawtransaction there.

jonasschnelli · 2015-04-24T09:35:48Z

@TheBlueMatt Thank you for your tweaks! Will try to go through the optimizing commits but need a clear head for that. Will do it soon.

TheBlueMatt · 2015-04-25T01:33:14Z

I added two more commits to that tree and made a nice rebased version at https://github.com/TheBlueMatt/bitcoin/commits/frt2

TheBlueMatt · 2015-04-30T20:48:41Z

Rebased frt2. @jonasschnelli do you want to review my changes and merge them here, or should I just open a new pull request? I'd like to keep this moving.

jonasschnelli · 2015-04-30T20:56:43Z

closing in favor of #6088

Support watchonly in fundrawtransaction, CreateTransaction, SelectCoins and coin selection in general. Coin selection is exposed over RPC through fundrawtransaction, and watchonly can be enabled by passing includeWatching true (defaults to false). fundrawtransaction will first attempt to fund a transaction without using watchonly, even when includeWatching is enabled. When this fails, an includeWatching attempt is made. When an includeWatching attempt at coin selection is performed (in CreateTransaction), and all watchonlys are consumed leaving no funds available for a fee, then CreateTransaction will not include a fee in the transaction. Also, includeWatching tests (for fundrawtransaction). See also: bitcoin#5503

jonasschnelli force-pushed the 2014_12_fundtransaction branch from 62ef48e to 88de6ee Compare December 17, 2014 21:23

aalness reviewed Dec 18, 2014
View reviewed changes

src/rpcrawtransaction.cpp Outdated

Copy link

Contributor

aalness Dec 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/exiting/existing

jonasschnelli force-pushed the 2014_12_fundtransaction branch 3 times, most recently from e1ea764 to db8b682 Compare December 20, 2014 20:51

jonasschnelli force-pushed the 2014_12_fundtransaction branch from db8b682 to a271e54 Compare December 20, 2014 21:10

kanzure mentioned this pull request Dec 21, 2014

Implement watchonly for fundrawtransaction #5524

Closed

jonasschnelli force-pushed the 2014_12_fundtransaction branch from a271e54 to 3ab9e72 Compare December 22, 2014 08:22

fanquake reviewed Dec 27, 2014
View reviewed changes

jonasschnelli force-pushed the 2014_12_fundtransaction branch from 92dcfa0 to 1f8f85b Compare December 27, 2014 19:52

laanwj added Docs RPC/REST/ZMQ and removed Docs labels Jan 8, 2015

laanwj added the Wallet label Feb 27, 2015

laanwj added this to the 0.11.0 milestone Feb 27, 2015

jonasschnelli force-pushed the 2014_12_fundtransaction branch from 1f8f85b to 0e093a7 Compare March 5, 2015 07:53

jonasschnelli force-pushed the 2014_12_fundtransaction branch 2 times, most recently from bcd0359 to 9ffa175 Compare April 20, 2015 13:46

jonasschnelli added 8 commits April 21, 2015 20:25

[RPC] fundrawtransaction basics

8369b93

[RPC] add support for existing vins for fundrawtransaction

111b248

[RPC] add simple unittest for fundrawtransaction (increase test cov…

d0ea91a

…erage)

[RPC] fundrawtransaction overhaul

7863a70

- fix typo - fix RPCTypeCheck for fundrawtransaction - some comments - merged with subtractFeeFromAmout patch (non trivial)

[RPC] fundrawtransaction dummy signing / ser. length calculation

5ef0b33

- serialize transaction size calculation (aka dummy-signing) without the need of signing the transaction (wallet can be locked to use fundrawtransaction) - rename VINS to vInputs

[moveonly] move fundrawtransaction() rpc call to rpcwallet.cpp

50fc9e8

fundrawtransaction requires a wallet and therefore it belongs to rpcwallet.cpp

add wallet-is-present check for fundrawtransaction

4109df9

rpc dispatch tables reqWallet has been removed.

[QA] adapt generate instead of setgenerate for fundrawtransaction tests

79858cd

jonasschnelli force-pushed the 2014_12_fundtransaction branch from 9ffa175 to 79858cd Compare April 21, 2015 18:25

TheBlueMatt added 2 commits April 24, 2015 10:23

Fix whitespace errors

3e79140

# Conflicts: # src/rpcserver.cpp

Tweak fundrawtransaction help text and return the fee as a float

7393177

TheBlueMatt added 2 commits April 24, 2015 11:18

Test inputs are not modified in fundrawtransaction

3f66c2e

Also return changepos from fundrawtransaction

840b89b

# Conflicts: # src/wallet/rpcwallet.cpp

jonasschnelli force-pushed the 2014_12_fundtransaction branch from f1e48f4 to 840b89b Compare April 24, 2015 09:19

TheBlueMatt mentioned this pull request Apr 30, 2015

fundrawtransaction #6088

Merged

jonasschnelli closed this Apr 30, 2015

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

[RPC] fundrawtransaction #5503

[RPC] fundrawtransaction #5503

Uh oh!

Conversation

jonasschnelli commented Dec 17, 2014

Uh oh!

jonasschnelli commented Dec 17, 2014

Uh oh!

aalness Dec 18, 2014

Choose a reason for hiding this comment

Uh oh!

aalness commented Dec 18, 2014

Uh oh!

gmaxwell commented Dec 18, 2014

Uh oh!

gmaxwell commented Dec 18, 2014

Uh oh!

kanzure commented Dec 19, 2014

Uh oh!

kanzure commented Dec 20, 2014

Uh oh!

jonasschnelli commented Dec 20, 2014

Uh oh!

jonasschnelli commented Dec 22, 2014

Uh oh!

fanquake Dec 27, 2014

Choose a reason for hiding this comment

Uh oh!

jonasschnelli Dec 27, 2014

Choose a reason for hiding this comment

Uh oh!

laanwj commented Feb 27, 2015

Uh oh!

jonasschnelli commented Apr 16, 2015

Uh oh!

jonasschnelli commented Apr 21, 2015

Uh oh!

TheBlueMatt commented Apr 24, 2015

Uh oh!

jonasschnelli commented Apr 24, 2015

Uh oh!

TheBlueMatt commented Apr 24, 2015

Uh oh!

TheBlueMatt commented Apr 24, 2015

Uh oh!

jonasschnelli commented Apr 24, 2015

Uh oh!

TheBlueMatt commented Apr 25, 2015

Uh oh!

TheBlueMatt commented Apr 30, 2015

Uh oh!

jonasschnelli commented Apr 30, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants