Revised translation process doc #5413
Conversation
|
Thanks, I'll read it in detail later but such substantial updates to docs are very welcome |
doc/translation_process.md
Outdated
There was a problem hiding this comment.
The path has since changed to src/. This needs to be updated.
|
You can add the translators mailing list as another point of contact https://groups.google.com/forum/#!forum/bitcoin-translators |
|
I'd also like to add a note about translation files being updated periodically (most likely for pre-releases), and code with new translations not requiring any translation file updates in the PR - mostly as it can complicate merges. |
Yes - note that it is already mentioned in README.md, but repeating it here doesn't hurt. |
doc/translation_process.md
Outdated
There was a problem hiding this comment.
I think it would be best to only mention this once under the contact section below , and here refer to that.
|
Changes look good to me, ACK, let me know when this is ready for merging. |
|
@laanwj I've updated the doc based on feedback. Should be ok to merge. |
|
ACK changes. Can you squash your commits? |
blakejakopovic
force-pushed
the
revise-transation-doc
branch
from
c565986 to
88eb44d
Compare
88eb44d Revised translation process doc (Blake Jakopovic)
Pull bitcoin#5413 was not rebased after deterministic signing was merged (bitcoin#5227), so the testcases had to be regenerated using UPDATE_JSON_TESTS.
3 participants
While becoming more familiar with Bitcoin Core, I came across
doc/translation_process.md. I felt it could use a refresh, so I've rewritten it to hopefully make it more clear for first time readers, while also being useful as a reference guide. I've kept all previous information. The new stuff is mostly just reformatting, and adding additional details.If someone could please review it technically, to catch any mistakes.
Due to the diff being so messy, here is a link to the original for reference and comparison.
doc/translation_process.md (to be replaced).