[REST] make selection of output-format mandatory, support dot url syntax #5376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasschnelli
force-pushed
the
rest-format-options
branch
from
fdad684 to
ff05f57
Compare
Member
|
Concept ACK, but I wouldn't do the case insensitivity. That just means more combinations to support in the future. Also, coding style (spaces after if etc). |
Member
|
Agree with sipa. Please don't leave any wiggling room in the REST API. Aliasing is generally bad, for example with regard to webcaches and such. One URL should map to one query. |
jonasschnelli
force-pushed
the
rest-format-options
branch
from
ff05f57 to
a97233a
Compare
Contributor
Author
|
Agreed. It was a stupid idea to support uppercase/mixed-case URIs. |
Member
|
utACK |
jonasschnelli
force-pushed
the
rest-format-options
branch
2 times, most recently
from
bbada20 to
bea2170
Compare
Contributor
Author
|
Update coding style by auto.-reformatting with the src/.clang-format file. |
jonasschnelli
force-pushed
the
rest-format-options
branch
from
bea2170 to
50baa4f
Compare
Member
|
Looks good to me now. |
1. Remove the default format (binary) because `rest/block/<hash>/Hex` would end up delivering binary data. 2. List available formats when chosen format was not found (reduces need for documentation) 3. Change url syntax to dot extension like format chosing (like `rest/tx/<hash>.json`
jonasschnelli
force-pushed
the
rest-format-options
branch
from
50baa4f to
8a5c951
Compare
Contributor
|
Looks good, will test |
Member
|
Slightly tested ACK |
laanwj
added a commit
that referenced
this pull request
Dec 2, 2014
8a5c951 [REST] make selection of output-format mandatory, support dot url syntax (Jonas Schnelli)
laanwj
added a commit
that referenced
this pull request
Dec 2, 2014
reddink
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
May 27, 2020
(cherry picked from commit 90f7aa7)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rest/block/<hash>/Hexwould end up delivering binary data.rest/tx/<hash>.json(as originally mentioned in Add unauthenticated HTTP REST interface #2844)