print the caught error instead of raising an error #5360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Seems to be a follow-up to #5354 |
Member
|
Slightly tested ACK. BTW unrelated to this pull, this script is a pain to set up and is a mess.
Anyone volunteering to give this a overhaul? Or would it be better to just remove it? Main argument I've heard for including this is that entering the |
laanwj
added a commit
that referenced
this pull request
Mar 18, 2015
71acb86 print the caught error instead of raising an error (Heath)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously bitrpc was returning generic errors. I threw in a raise which provides useful info.
@laanwj mentioned it wouldn't be a good idea to raise after catching the exception.
And so I changed it. Apologies for opening a new PR instead of updating the existing one.