Implement test for merkle tree malleability in CPartialMerkleTree #5349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yes, bitcoinj uses a completely straight line translation of your code to Java. Equivalent commit is here: Thanks! Also thanks to Matt for pointing this pull req out to me. |
Member
Author
|
@mikehearn Heh, good that you notice. I was convinced that BitcoinJ actually implemented the rule as written in the BIP (on the other hand, until recently I was also convinced that Bitcoin Core implemented it too). |
Contributor
|
@sipa you underestimate my laziness, then :) |
This is a check that is mentioned in BIP 37, but never implemented in the reference code. As Bitcoin Core so far never decodes partial merkle trees, this is not a problem. But perhaps others use the code as a reference.
Member
Author
|
Rebased. |
Member
laanwj
added a commit
that referenced
this pull request
Jan 2, 2015
0125988 Implement test for merkle tree malleability in CPartialMerkleTree (Pieter Wuille)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a check that is mentioned in BIP 37, but never implemented in the reference code. As Bitcoin Core so far never decodes partial merkle trees, this is not a problem. But perhaps others use the code as a reference.
Not intended for 0.10.