Skip to content

Conversation

@jonasschnelli
Copy link
Contributor

No description provided.

@Diapolo
Copy link

Diapolo commented Nov 21, 2014

Should the check be >=?

@theuni
Copy link
Member

theuni commented Nov 21, 2014

Could you elaborate on what the actual compatibility issue is here, please? The commit message/pull description aren't really helpful.

@theuni
Copy link
Member

theuni commented Nov 21, 2014

Nm, I see it now over at #5296. Would be helpful if you could reference the previous discussion in follow-ups like this.

@jonasschnelli
Copy link
Contributor Author

Yes. Sorry. I forgot to reference #5296.
The problem is, that the enum used in the pull 5296 is only available in qt5.

@laanwj
Copy link
Member

laanwj commented Nov 24, 2014

Should the check be >=?

I think so too. Would be more consistent. Although I doubt there is any version that advertises QT_VERSION==0x050000.

@laanwj laanwj added the GUI label Nov 24, 2014
@laanwj laanwj added this to the 0.10.0 milestone Nov 24, 2014
laanwj pushed a commit that referenced this pull request Nov 24, 2014
@laanwj
Copy link
Member

laanwj commented Nov 24, 2014

Merged via c5a2282

@laanwj laanwj closed this Nov 24, 2014
reddink pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request May 27, 2020
Rebased-From: 7f33d2c
Github-Issue: bitcoin#5344
(cherry picked from commit c5a2282)

# Conflicts:
#	src/qt/guiutil.h
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants