Skip to content

[Wallet] Reduce minTxFee for transaction creation to 1000 satoshis #5209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Nov 26, 2014
Merged

[Wallet] Reduce minTxFee for transaction creation to 1000 satoshis #5209

laanwj merged 1 commit into from
Nov 26, 2014

Conversation

@cozz
Copy link
Contributor

@cozz cozz commented Nov 4, 2014

Make minTxFee match minRelayTxFee one year after #3305

@laanwj laanwj added the Wallet label Nov 5, 2014
@laanwj
Copy link
Member

laanwj commented Nov 5, 2014

Makes sense. utACK.

@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Nov 7, 2014

utACK

@cozz cozz mentioned this pull request Nov 14, 2014
Merged
@luke-jr
Copy link
Member

luke-jr commented Nov 14, 2014

#3305 only changed the minimum relay fee. I'm not sure anyone would mine transactions using fees this low...

@morcos
Copy link
Contributor

morcos commented Nov 14, 2014

As far as I can tell transactions with fees down to the minimum relay fee are typically confirmed within 3 blocks (70-80%) and almost always confirmed within 8 blocks (over 99%).

@cozz
Copy link
Contributor Author

cozz commented Nov 14, 2014

Miners judge by the minimum relay fee,
see 037b4f1#diff-4a59b408ad3778278c3aeffa7da33c3c

@luke-jr
Copy link
Member

luke-jr commented Nov 14, 2014

Wow, that snuck in with absolutely no discussion as to the policy change it was affecting... :/

@cozz
Copy link
Contributor Author

cozz commented Nov 14, 2014

heres the pull request #3838

@laanwj laanwj added this to the 0.10.0 milestone Nov 19, 2014
@laanwj
Copy link
Member

laanwj commented Nov 20, 2014

Can we have some ACKs/NACKs here?
@gavinandresen @sipa @gmaxwell

@sipa
Copy link
Member

sipa commented Nov 20, 2014

Relying on the numbers above, utACK.

@jtimon
Copy link
Contributor

jtimon commented Nov 20, 2014

This is just a default and can be configured by wallet users, right?
If so, utACK.

@gmaxwell
Copy link
Contributor

gmaxwell commented Nov 21, 2014

I don't have a strong opinion. I think we made an error lowering the relay fee previously, but fortunately no doom has yet come with it. Since reports claim the lower amounts are confirming in sane times it seems okay to me.

@laanwj laanwj merged commit 9b1627d into bitcoin:master Nov 26, 2014
laanwj added a commit that referenced this pull request Nov 26, 2014
@laanwj
Merge pull request #5209
124b489 
9b1627d [Wallet] Reduce minTxFee for transaction creation to 1000 satoshis (Cozz Lovan)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Wallet

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

8 participants

@cozz @laanwj @TheBlueMatt @luke-jr @morcos @sipa @jtimon @gmaxwell