consensus lib work: Separate protocol versioning from clientversion #5164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Arguably version.h should move to core/ after this, but I'll save that for later to cut down on includes fixups. |
theuni
force-pushed
the
reducedeps10
branch
2 times, most recently
from
a07f20f to
71697f9
Compare
Member
|
utACK. Yes, please. I've always hated how we mixed these. |
Member
|
utACK |
laanwj
added a commit
that referenced
this pull request
Oct 30, 2014
71697f9 Separate protocol versioning from clientversion (Cory Fields)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As subject implies. Libs need to be aware of the protocol version. Together with #5162, this is the last of the big code movement for the lib for 0.10.
This is move-only. Git even detects the file movement, so this one is easy enough to verify via the web interface.