consensus lib work: split CPubKey and friends out of key.o #5162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s there Eventually (after 0.10) these files will hold the logic for crypto verification routines, and CKey/CPubKey will call into them.
Member
Author
Member
There was a problem hiding this comment.
Please make this just MIT, especially in new files
Member
|
Verified move-only apart from noted exception above. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next-to-last major movement necessary for libbitcoinconsensus. After this and version movement (see next PR), only script interpreter error handling remains.
Split CPubKey and friends out so that they can be used without CKey's dependencies. Stub files have been created for handling crypto functionality without any core deps (eccryptoverify.h/cpp). Eventually these will handle crypto-level key functions, and CKey/CPubKey will call into them. Because some code changes are needed for that, and it's not strictly necessary for the verification lib for 0.10, that change has been skipped here.