Skip to content

consensus lib work: split ec openssl wrapper into separate files #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sipa merged 2 commits into from
Oct 28, 2014
Merged

consensus lib work: split ec openssl wrapper into separate files #5118

sipa merged 2 commits into from
Oct 28, 2014

Conversation

@theuni
Copy link
Member

@theuni theuni commented Oct 22, 2014

This unchains CKey/CPubKey from openssl and will allow us to use EC functionality from script without depending on anything else.

Upcoming PR's will take advantage of this, I've split it up for the sake of review sanity. I can add those here if it would be preferred though.

@sipa
Copy link
Member

sipa commented Oct 24, 2014

utACK; didn't verify move only

@laanwj
Copy link
Member

laanwj commented Oct 27, 2014

Verified that a43447c8168a30c78f054878ffdccbe7deff557b is move-only apart from

  • Added method CECKey::SanityCheck (which contains only moved code)

@theuni
Copy link
Member Author

theuni commented Oct 27, 2014

@laanwj updated to use begin_ptr as requested.

@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Oct 28, 2014 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

ACK commithash 50f71cd52e1eb35b10564f73a54fe5ea5b245418
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUTuBGAAoJEIm7uGY+LmXO+koQANK9SjJ2eWkVriCvGw68913o
Ezb70u3URN2aDWdfcxu8RTypbYXqlo9E2Lyq4LYsiLFZ57M/poOK4Vc0PeTs5YDt
cg/1gpSLhVVdK9jyJfBaab/1ncE8nXeBCiZ480naILq0KhaXwPRi+vPCKnFMGid/
PRrhfXBgLUnKNRwGStF20NcjElJNJUMDFeObPcJR/HeVGQcYyEeuNwxNUM5zHH+y
qB06VHuWE9saELWRO1ffH2svFO/QzdGQAZamBEzQCM5rIdGsChiH/fqeRM5rCJTO
rA6Gr4sJ0QftY5J0FEfQB/+Ory/wVmYW2vOgyt4HTGvOGLlaM1jXZr78zMbeRoUr
xJBXrxdGNcFYpIgO4HmD2+dLnND7f5kxwe6dBx//8B10iefK64/4zIV1wMibhTHt
it3fybk06JTbTL6ct13GvoLOs4q3gKJhAQ1WSC4dCOND5e5+BBjNCs5UDEpoATp/
TVa17pRSe8Ws5x9CXdyooWbLlBnwWcenj3WbujjjfPj+0AdOP6iUT973kV1ZsSA0
tbmDAt4FQgB4iN28LSqV5MtjoJVXx0au6O98ZquowiNyYeoe80VSs9OzLt6mk/Vk
tbUTyfi/KniRN2Qh2isIIf3emOAhscW5PnPYDboBCOC9+lU5+wbmfo6EnPV+SAkz
ax1u0qLBRu9fJ+mzJmPQ
=xcBz
-----END PGP SIGNATURE-----

@sipa sipa mentioned this pull request Oct 28, 2014
Merged
@sipa
Copy link
Member

sipa commented Oct 28, 2014

ACK, verified that the code in ecwrapper.cpp is moved from key.cpp.

@sipa sipa merged commit 50f71cd into bitcoin:master Oct 28, 2014
sipa added a commit that referenced this pull request Oct 28, 2014
@sipa
Merge pull request #5118
068b7f8 
50f71cd boost: code movement only: split CECKey into separate files (Cory Fields)
bdaec6a boost: remove CPubKey dependency from CECKey. Follow-up of e405aa4 (Cory Fields)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theuni @sipa @laanwj @TheBlueMatt