Only include undo.h from main.cpp #5111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtimon
force-pushed
the
core2
branch
2 times, most recently
from
13a7453 to
da94974
Compare
jtimon
changed the title
Contributor
Author
|
Rebased to make it more readable. |
Member
|
utACK! |
Contributor
Author
|
Nits addressed. |
Member
|
Needs rebase. |
Contributor
Author
|
Rebased and squashed the commits solving the nits. |
Member
|
utACK still |
Contributor
Author
|
Needed rebase for the doxygen comments. |
Contributor
Author
|
Rebased adding @theuni 's suggestions. |
src/main.cpp
Outdated
Contributor
Author
|
Sorry, mistake rebasing... |
Contributor
Author
|
Rebased |
Contributor
Author
|
Rebased again. |
Contributor
|
ACK |
furszy
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Jul 16, 2020
9670a84 Move UndoWriteToDisk() and UndoReadFromDisk() to anon namespace (random-zebra) 4fe609f Decouple CBlockUndo from CDiskBlockPos (jtimon) 9703b0e Decouple miner.o and txmempool.o from CTxUndo (random-zebra) cdc8cdc Decouple CCoins from CTxInUndo (jtimon) Pull request description: Backport bitcoin#5111 Original description: > Built on top of bitcoin#5100. > coins.o doesn't need to depend on undo.h (Decouple CCoins from CTxInUndo) > miner.o neither (Decouple miner.o from CTxUndo) > Finally, CBlockUndo can be moved from main.h to undo.h if it is first decoupled from CDiskBlockPos. ACKs for top commit: furszy: utACK 9670a84 Fuzzbawls: re-utACK 9670a84 Tree-SHA512: d77110525f50a3085013ca9cb87550ff786ee06c5b938a9002fe3a434c7a35a425238d1b623a01c26bebb5075c7e1bea9bc2ff4638c0c1190df15196b7097e55
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #5100.
coins.o doesn't need to depend on undo.h (Decouple CCoins from CTxInUndo)
miner.o neither (Decouple miner.o from CTxUndo)
Finally, CBlockUndo can be moved from main.h to undo.h if it is first decoupled from CDiskBlockPos.