Skip to content

Conversation

@rebroad
Copy link
Contributor

@rebroad rebroad commented Oct 18, 2014

I've been developing these improvements in parallel with headersfirst8.

It's now been optimised for use with early to late block chain so adapts to the block sizes and also the bandwidth of each node to make optimal use of the connections available.

The sipa disconnect code has been disabled as it usually disconnected the most important node (with my changes), but it will still display when the logic would have executed.

Please do test and compare download times with before this test and I'm sure you'll see improvements.

It's not yet optimised for use with earlier blocks (which were small enough to download in batches of 500 each), but that will be coming shortly. Raising the pull request so that people can view and comment on some of the changes.

@laanwj laanwj added the P2P label Oct 22, 2014
@rebroad rebroad force-pushed the headersfirst8-improvements branch 2 times, most recently from cf739b6 to 410dbef Compare October 23, 2014 08:22
@rebroad
Copy link
Contributor Author

rebroad commented Oct 23, 2014

There are probably some commits in here that can be removed. I've kept it fairly granular so that some of the changes are easily optional. The big change is the commit called "Track partial download progress...", and I've recently updated this so that it now changes the window size per node based upon the bandwidth each note is achieving.

@laanwj Is it worth tagging members of the core development team in a comment to draw their attention to this?

@laanwj
Copy link
Member

laanwj commented Oct 23, 2014

@rebroad Possibly. But it could be that this list of change is too intimidating for one pull, and it may be better to trickle the changes instead of having one umbrella "Headersfirst8 improvements".

@rebroad rebroad force-pushed the headersfirst8-improvements branch 19 times, most recently from e56b9a7 to 7ba63dd Compare October 28, 2014 13:35
@rebroad rebroad changed the title Headersfirst8 improvements Initial Block Download optimisations Oct 28, 2014
@rebroad rebroad force-pushed the headersfirst8-improvements branch 3 times, most recently from ebb170f to 854367d Compare October 29, 2014 08:47
@rebroad
Copy link
Contributor Author

rebroad commented Oct 30, 2014

tumbleweed

@rebroad rebroad force-pushed the headersfirst8-improvements branch from 854367d to 86de964 Compare October 30, 2014 02:33
@rebroad rebroad force-pushed the headersfirst8-improvements branch 6 times, most recently from 2c6c439 to 585e89c Compare November 3, 2014 04:13
@rebroad rebroad force-pushed the headersfirst8-improvements branch from 585e89c to ee457ac Compare November 10, 2014 08:17
@rebroad
Copy link
Contributor Author

rebroad commented Nov 10, 2014

I don't know what travis is talking about - it seems to be running an old version that isn't present in the current branch.

@rebroad rebroad force-pushed the headersfirst8-improvements branch from ee457ac to e50e834 Compare November 12, 2014 11:29
@rebroad rebroad closed this Nov 12, 2014
@rebroad rebroad reopened this Nov 12, 2014
@rebroad rebroad force-pushed the headersfirst8-improvements branch from e50e834 to 96e8bf5 Compare November 12, 2014 11:48
@rebroad rebroad force-pushed the headersfirst8-improvements branch from 96e8bf5 to e2b98a9 Compare November 13, 2014 01:34
@laanwj
Copy link
Member

laanwj commented Mar 18, 2015

Needs rebase.

@laanwj laanwj closed this Jul 10, 2015
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants