Add LIBTOOLFLAGS CXX tag to qt makefile include #5092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ACK. The issue here is that when automake encounters .mm files, it tags the final object as requiring an objective c++ linker. That shouldn't be a problem except that it doesn't communicate well with libtool. I still haven't dug into where the communication breakdown is. I suspect that either it tells libtool to use the OBJCXX tag which libtool doesn't understand, or that automake itself doesn't have an OBJCXX tag case, so it just skips setting one. Either way, manually specifying the CXX tag should be perfectly safe. |
Contributor
|
utACK |
laanwj
added a commit
that referenced
this pull request
Oct 17, 2014
6f155bd Add LIBTOOLFLAGS CXX tag to qt makefile include (Michael Ford)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #4993
@theuni As far as I can tell it's only needed in this spot. Test bitcoin_bitcoin-qt seems to run fine.
I'm guessing because