-
Notifications
You must be signed in to change notification settings - Fork 38.7k
cleanup new script files (no code changes) #4881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Diapolo
commented
Sep 9, 2014
- add missing header end comments
- ensure alphabetical ordering
- update copyright year and license
|
I was only fixing the makefile in #4755 and @TheBlueMatt already nit it, hehe. |
|
Can we change the license of existing code? |
|
As discussed before we're not changing the license, just clarifying it. |
|
@sipa Dunno, @TheBlueMatt suggested this and I just included it, because this is a seperate folder anyway ( |
|
ACK anyhow. |
|
I thought we weren't sure about legality of changing the license (even just the name) of existing code, but were going to use MIT (without X11) in new code only. I don't care either way - just want to make sure we know what we're doing. |
|
The latest license discussion was in #4832. |
|
ACK |
|
Anything left that needs to be done here to help speed up merge? |
- add missing header end comments - ensure alphabetical ordering - update copyright year and license
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4881_2d79bba36b028dd803fb17124420b9d209b842b6/ for binaries and test log. |
|
I don't think so, it looks good to me as it is. |
2d79bba cleanup new script files (no code changes) (Philip Kaufmann)