Skip to content

Only need to subtract 1 (originally time was in seconds). #4828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rebroad wants to merge 1 commit into from
Closed

Only need to subtract 1 (originally time was in seconds). #4828

rebroad wants to merge 1 commit into from
+1 −1

Conversation

@rebroad
Copy link
Contributor

@rebroad rebroad commented Sep 3, 2014

#3514 changed the time used with askfors from seconds to milliseconds but the change introduced an assumption that the time needed to be reduced by 1 second, when it fact it was the number that needed to be reduced by 1.

@BitcoinPullTester
Copy link

BitcoinPullTester commented Sep 3, 2014

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4828_469f440924f120f34c6e065d236e8ca230456445/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@TheBlueMatt
Copy link
Contributor

TheBlueMatt commented Sep 3, 2014

Can you also add a comment to explain why the -1 is there to begin with?

@rebroad
Copy link
Contributor Author

rebroad commented Sep 3, 2014

@TheBlueMatt I used to understand why the -1 was there long ago, but I've lost the memory of why it was needed now... I'd have to relook at the code from years ago to work it out.

@laanwj laanwj mentioned this pull request Sep 4, 2014
Closed
@laanwj
Copy link
Member

laanwj commented Sep 10, 2014

Closing in favor of #4831 which does away with this voodoo.

@laanwj laanwj closed this Sep 10, 2014
@rebroad rebroad mentioned this pull request Mar 8, 2016
Closed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rebroad @BitcoinPullTester @TheBlueMatt @laanwj