Skip to content

Improve askfor logging (show time it will be requested by) #4827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rebroad wants to merge 1 commit into from
Closed

Improve askfor logging (show time it will be requested by) #4827

rebroad wants to merge 1 commit into from

Conversation

@rebroad
Copy link
Contributor

@rebroad rebroad commented Sep 3, 2014

This improves logging of askfors. Firstly it now shows the time the request will be sent (rather than the incorrect time 2 minutes earlier). Also, the number of the time is now omitted since this now isn't useful since time went from seconds to microseconds.

@BitcoinPullTester
Copy link

BitcoinPullTester commented Sep 3, 2014

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4827_3d06d2b4d46ddd536383b560a99a41538409c618/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@laanwj laanwj mentioned this pull request Sep 4, 2014
Closed
@laanwj
Copy link
Member

laanwj commented Sep 18, 2014

Closing in favor of #4831.

@laanwj laanwj closed this Sep 18, 2014
@rebroad rebroad deleted the AskforDebug branch March 8, 2016 10:26
@rebroad
Copy link
Contributor Author

rebroad commented Mar 8, 2016

@laanwj Since #4831 didn't get merged, can this perhaps be reopened?

@laanwj
Copy link
Member

laanwj commented Mar 14, 2016

Reopen button is greyed out here.
(the AskForDebug branch has been deleted)

@maflcko
Copy link
Member

maflcko commented Mar 14, 2016

There is no discussion in this pull, so it's save to reopen a rebased version, I guess.

@rebroad rebroad restored the AskforDebug branch September 1, 2016 06:59
@rebroad
Copy link
Contributor Author

rebroad commented Sep 1, 2016

I've restored the branch. Github isn't saying it needs rebasing but that might be because it needs re-opening before it will determine that...

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rebroad @BitcoinPullTester @laanwj @maflcko