Skip to content

Move checkpoint data selection to chainparams #4801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jtimon wants to merge 2 commits into from
Closed

Move checkpoint data selection to chainparams #4801

jtimon wants to merge 2 commits into from

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Aug 31, 2014

This way we avoid the calls to Params().NetworkID() in checkpoints.cpp.
If at some point we're going to read the chainparams from data files, we probably want to put the checkpoint data there as well

@BitcoinPullTester
Copy link

BitcoinPullTester commented Aug 31, 2014

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4801_0781bde927f8cbf55693eb63ef4c6ac96886d49f/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

This was referenced Aug 31, 2014
Merged
Merged
@jtimon
Copy link
Contributor Author

jtimon commented Sep 2, 2014

Included in #4802, closing.

@jtimon jtimon closed this Sep 2, 2014
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtimon @BitcoinPullTester