Skip to content

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Aug 30, 2014

Continues #4793 (completing the set of PRs #3839 #4422 #4446 #4457 #4457 #4603 #4377 #4506 #4793).

@petertodd
Copy link
Contributor

Can we s/Proof/CProof/ to keep naming consistent?

@jtimon
Copy link
Contributor Author

jtimon commented Aug 31, 2014

Renamed Proof -> CProof

@petertodd
Copy link
Contributor

Thanks!

@jtimon
Copy link
Contributor Author

jtimon commented Sep 1, 2014

Bringing description from #4793 here:

Following @laanwj 's advice of only moving ScanHash, I found another solution to encapsulate the miner's pow without removing the miner's optimization, which was rejected in #4423
But I would like to slightly change the behavior.
Commit "Replace proof.nNonce >= 0xffff000 with an iteration counter" should be either rejected or squashed into "proof.nNonce >= 0xffff0000 -> proof.OutOfRangeSolution()" (and of course that 1000 in the for is open for bike-shedding).
"Small miner optimization" also should be rejected or rebased in "Remove testnet's special case from miner.cpp".
I think these 2 functional changes are meaningless enough that can be safely accepted.
I would also be happy to just remove the hashmeter and the resulting PR would be simpler.

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4794_d93c180cdf32141f857c1d61c2e85cae8406ec6f/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@jtimon
Copy link
Contributor Author

jtimon commented Sep 2, 2014

Closing until #4506 and #4793 are merged

@jtimon jtimon closed this Sep 2, 2014
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants