Skip to content

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Aug 28, 2014

It's only used in one place and CScriptCheck can be used directly instead.
Also remove CScriptCheck::nHashType since was always 0.
In preparation of #4555

@jtimon jtimon changed the title Remove unused function main:VerifySignature Remove unused function main::VerifySignature Aug 28, 2014
@jtimon jtimon changed the title Remove unused function main::VerifySignature Remove CScriptCheck::nHashType (was always 0) Aug 28, 2014
@sipa
Copy link
Member

sipa commented Aug 30, 2014

Needs rebase, but ut ACK.

@laanwj
Copy link
Member

laanwj commented Aug 30, 2014

Agree on removing the VerifySignature function that is only used by the tests.

NACK on partially removing CScriptCheck::nHashType. Either it should be removed completely and this removal propagated through VerifyScript, or it would be better to keep it like this. Mind that CScriptCheck is meant to be a closure around VerifyScript (so should expose the same arguments). Now you just push the hardcoded 0 to CScriptCheck::operator()().

@laanwj
Copy link
Member

laanwj commented Aug 30, 2014

Oh, that's what you do in #4555, well then it's fine with me.

@jtimon
Copy link
Contributor Author

jtimon commented Aug 30, 2014

Rebased

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4775_5ad29370edc22558539bd89135c02d3de4c7bc52/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@TheBlueMatt
Copy link
Contributor

ut ACK.

@jtimon
Copy link
Contributor Author

jtimon commented Sep 8, 2014

Included in #4555, after #4754 has been merged there's no point in keeping this one separated.

@jtimon jtimon closed this Sep 8, 2014
@jtimon jtimon deleted the unused branch September 8, 2014 21:02
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants