[Qt] Call checkBalanceChanged() periodically instead for every updated tx #4712
Conversation
|
Untested ACK |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4712_80daee0fb585762d303503f32f8efa0e625f152f/ for binaries and test log. |
|
Untested ACK |
80daee0 [Qt] Call checkBalanceChanged() periodically instead for every updated transaction (Cozz Lovan)
…d transaction Rebased-from: 80daee0fb585762d303503f32f8efa0e625f152f bitcoin/bitcoin#4712
…d transaction Rebased-from: 80daee0 bitcoin#4712
…d transaction Rebased-from: 80daee0 bitcoin#4712
…d transaction Rebased-from: 80daee0 bitcoin#4712
…d transaction Rebased-from: 80daee0 bitcoin#4712
4 participants
checkBalanceChanged() is quite expensive on larger wallets as we loop mapWallet
several times for each balance-type.
There already is a periodical function pollBalanceChanged().
So instead of calling checkBalanceChanged() for each updated transaction, set a flag
fForceCheckBalanceChanged, which forces pollBalanceChanged() to check the balance
on the next run.
For example
importaddress mvqaxopu9Uef2qjXSV3fGrp6DcEYnCoYWK
adds like 20000 transactions to the wallet.
This means after rescan currently we loop mapWallet 120000 times,
just to check the balance, which causes 100% cpu for a while.
Unrelated change: Move showProgress signal after the QueueProcessing, so that the progressbar is still shown, while the 20000 txs get added to the GUI.