Skip to content

Conversation

@cozz
Copy link
Contributor

@cozz cozz commented Aug 15, 2014

I was wondering why adding 18000 transactions to the wallet takes ages.
One of the reasons is CWallet::OrderedTxItems(..).
So maintain the map in-memory instead of generating it all the time.
This pull should not change any functionality.

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4702_6b18a63a5099a6011187f20d05f2357a5bb4b2ea/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@cozz
Copy link
Contributor Author

cozz commented Oct 3, 2014

rebased

@laanwj
Copy link
Member

laanwj commented Feb 9, 2015

@jonasschnelli is working on larger changes to the wallet, and adding a 'netwallet' based on a new database. There doesn't seem to be much point in improving the performance of the legacy wallet, with risk of breaking things. So I'm closing this, sorry.

@laanwj laanwj closed this Feb 9, 2015
@ghost
Copy link

ghost commented Oct 26, 2015

Any news on this wallet by @jonasschnelli ? I ask because a number of useful ideas seem to have been by-passed in favor of this option.

@jonasschnelli
Copy link
Contributor

Still working on the wallet. Currently I'm exploring some hardware wallet stuff. Soon I'm back refactoring the wallet. Very likely I'm going to remove everything node related from my core-wallet fork and support SPV*RPC (qt) wallet connection to a trusted full node. Bundling the two (for deployment) could still be possible.

@maflcko
Copy link
Member

maflcko commented Oct 26, 2015

This seems related to #6851?

@ghost
Copy link

ghost commented Oct 26, 2015

hehehe, it'll be a year soon and likely any work you do will take a while longer. Why don't we re-consider the most useful pull requests and maybe merge them? Then later when your version becomes available, we can allow users to have a choice? I see no downside to this and would be willing to put in some hours towards these goals.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants