Skip to content

Strictly hash what is going to be signed #4695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jtimon wants to merge 4 commits into from
Closed

Strictly hash what is going to be signed #4695

jtimon wants to merge 4 commits into from

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Aug 13, 2014

Continues #4694.
Again, more important than the optimization, I think the end result is more readable.
It could be a little bit nicer by joining SignHash and Sign, but then multisig's performance would be hurt.

@jtimon jtimon mentioned this pull request Aug 13, 2014
Closed
@jtimon
Copy link
Contributor Author

jtimon commented Aug 14, 2014

Dependent on #4692

@jtimon
Copy link
Contributor Author

jtimon commented Aug 27, 2014

Rebased on top of #4754

@jtimon
Copy link
Contributor Author

jtimon commented Aug 31, 2014

Rebased on top of #4755

@jtimon jtimon force-pushed the nohash2 branch 3 times, most recently from d8712a7 to b0997d9 Compare September 2, 2014 01:14
@jtimon
Copy link
Contributor Author

jtimon commented Sep 2, 2014

Closing until #4754 is merged.

@jtimon jtimon closed this Sep 2, 2014
@jtimon jtimon reopened this Sep 8, 2014
@BitcoinPullTester
Copy link

BitcoinPullTester commented Sep 13, 2014

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4695_9aaf3b6c02e746d7db17ab260837f8736c99f4f0/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@jtimon
Copy link
Contributor Author

jtimon commented Sep 15, 2014

I think I've changed my mind, at least on removing SignN. Closing for now.

@jtimon jtimon closed this Sep 15, 2014
@sipa sipa mentioned this pull request Nov 4, 2014
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtimon @BitcoinPullTester @laanwj