Skip to content

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Aug 1, 2014

There's no need to declare external headers in tests, you can just include them.

@jgarzik
Copy link
Contributor

jgarzik commented Aug 1, 2014

ut ACK

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4617_f5745fa52a66ab9ba976e06de4881e981d9aa6b4/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@sipa
Copy link
Member

sipa commented Aug 1, 2014

Untested ACK

@jgarzik jgarzik merged commit f5745fa into bitcoin:master Aug 2, 2014
@jtimon jtimon deleted the whyextern branch August 11, 2014 02:11
@jtimon jtimon mentioned this pull request Aug 13, 2014
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants