Skip to content

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Aug 1, 2014

Rebased and bike-shed version of #4234

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4614_0adf98ed38c706ebae07a0d74bf6bab18e1b9f42/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@maaku
Copy link
Contributor

maaku commented Aug 1, 2014

I updated the original PR.

@laanwj
Copy link
Member

laanwj commented Aug 1, 2014

ACK
(checked that it only changes type names using sipa's git show --word-diff-regex='[[:alnum:]]+|[^[:space:]])

@gmaxwell
Copy link
Contributor

gmaxwell commented Aug 1, 2014

ACK. I like this, I generally prefer more specific typing.

@bpay
Copy link
Contributor

bpay commented Aug 1, 2014

Why the change to pass by const ref? For something that small you'll likely get better codegen just passing by value.

@sipa
Copy link
Member

sipa commented Aug 1, 2014

@bpay As long as CAmount is a simple type, yes.

@maaku
Copy link
Contributor

maaku commented Aug 2, 2014

Jorge, there's a number of locations in this pull request using int64 which have not been updated to use the new type. (Compare diffs with #4234, which is now properly rebased & updated.)

@jtimon
Copy link
Contributor Author

jtimon commented Aug 2, 2014

Let's just merge #4234 then, I'm closing this one.

@jtimon jtimon closed this Aug 2, 2014
@jtimon jtimon deleted the typedef2 branch August 11, 2014 20:12
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants