Skip to content

Rework block processing benchmark code #4593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Jul 30, 2014
Merged

Rework block processing benchmark code #4593

laanwj merged 1 commit into from
Jul 30, 2014

Conversation

@sipa
Copy link
Member

@sipa sipa commented Jul 26, 2014

  • Replace -benchmark (and the related fBenchmark) with a regular debug option, -debug=bench.
  • Increase coverage and granularity of individual block processing steps.
  • Add cummulative times.

Example output:

   - Load block from disk: 3.11ms [51.13s]
       - Connect 484 transactions: 4.14ms (0.009ms/tx, 0.005ms/txin) [64.37s]
     - Verify 860 txins: 4.25ms (0.005ms/txin) [66.98s]
     - Index writing: 1.22ms [33.53s]
     - Callbacks: 0.10ms [2.15s]
   - Connect total: 14.17ms [203.69s]
   - Flush: 1.00ms [19.88s]
   - Writing chainstate: 0.09ms [33.30s]
   - Connect postprocess: 0.23ms [5.15s]
 - Connect block: 11.96ms [313.16s]

Note that the subdivisions work backwards: the grand total is the last item, 'Connect transactions' is a part of 'Verify transactions', and 'Verify transactions', 'Index writing', and 'Callbacks' are part of 'Connect total'.

@sipa
Rework block processing benchmark code
d70bc52 
* Replace -benchmark (and the related fBenchmark) with a regular debug option, -debug=bench.
* Increase coverage and granularity of individual block processing steps.
* Add cummulative times.
@BitcoinPullTester
Copy link

BitcoinPullTester commented Jul 27, 2014

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4593_d70bc52ee31b8c4c87ee011625e7031c2dc89c0c/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@jgarzik
Copy link
Contributor

jgarzik commented Jul 29, 2014

ACK

1 similar comment
@laanwj
Copy link
Member

laanwj commented Jul 30, 2014

ACK

@laanwj laanwj merged commit d70bc52 into bitcoin:master Jul 30, 2014
laanwj added a commit that referenced this pull request Jul 30, 2014
@laanwj
Merge pull request #4593
efec4ec 
d70bc52 Rework block processing benchmark code (Pieter Wuille)
@jmcorgan jmcorgan mentioned this pull request Jul 30, 2014
Closed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sipa @BitcoinPullTester @jgarzik @laanwj