Skip to content

Optimization: only keep setBlockIndexValid entries that are possible improvements #4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sipa merged 1 commit into from
Jul 30, 2014
Merged

Optimization: only keep setBlockIndexValid entries that are possible improvements #4497

sipa merged 1 commit into from
Jul 30, 2014

Conversation

@sipa
Copy link
Member

@sipa sipa commented Jul 9, 2014

Before, we kept all valid CBlockIndex* entries in setBlockInvalidValid, but as it is only used to select potential new tips to activate, it suffices to only keep entries that are at least as good as the current tip.

This should save some memory in the stable synced state: 13 MiB on 64 bit, 8 MiB on 32 bit.

@sipa
Copy link
Member Author

sipa commented Jul 9, 2014

Thanks @BitcoinPullTester, fixed a bug.

@sipa
Copy link
Member Author

sipa commented Jul 11, 2014

Added some comments and an assert.

@BitcoinPullTester
Copy link

BitcoinPullTester commented Jul 11, 2014

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4497_714a3e6505d986d064d3a34038a724ac1cad5308/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@sipa sipa mentioned this pull request Jul 11, 2014
Merged
@laanwj
Copy link
Member

laanwj commented Jul 23, 2014

Tested ACK (ran on test node for two weeks without problems)

@jgarzik
Copy link
Contributor

jgarzik commented Jul 29, 2014

ut ACK

@sipa sipa merged commit 714a3e6 into bitcoin:master Jul 30, 2014
sipa added a commit that referenced this pull request Jul 30, 2014
@sipa
Merge pull request #4497
e8cb5c3 
714a3e6 Only keep setBlockIndexValid entries that are possible improvements (Pieter Wuille)
@sipa sipa deleted the optimset branch July 30, 2014 22:08
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sipa @BitcoinPullTester @laanwj @jgarzik