Skip to content

Bugfix: only remove actualy failed blocks from setBlockIndexValid #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Jul 24, 2014
Merged

Bugfix: only remove actualy failed blocks from setBlockIndexValid #4496

laanwj merged 1 commit into from
Jul 24, 2014

Conversation

@sipa
Copy link
Member

@sipa sipa commented Jul 9, 2014

Fix an unexposed bug in dealing with invalid blocks: only chains with actually invalid blocks should be removed from the set of potentially new tips.

Also, in case an error is found, the failed block itself must be removed from that set.

This would be exposed by #4468.

@sipa
Copy link
Member Author

sipa commented Jul 9, 2014

Oops, stale negation. Fixed.

@BitcoinPullTester
Copy link

BitcoinPullTester commented Jul 9, 2014

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4496_5734d4d1e6ee89361fc2484f5d33315397796c0d/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@sipa sipa mentioned this pull request Jul 11, 2014
Merged
@laanwj
Copy link
Member

laanwj commented Jul 23, 2014

Tested ACK

@laanwj laanwj merged commit 5734d4d into bitcoin:master Jul 24, 2014
laanwj added a commit that referenced this pull request Jul 24, 2014
@laanwj
Merge pull request #4496
70d0325 
5734d4d Only remove actualy failed blocks from setBlockIndexValid (Pieter Wuille)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sipa @BitcoinPullTester @laanwj