Skip to content

CBlockIndex()::SetNull() method to avoid code repetition #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Jul 7, 2014
Merged

CBlockIndex()::SetNull() method to avoid code repetition #4457

laanwj merged 1 commit into from
Jul 7, 2014
+7 −13

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Jul 2, 2014

Trivial refactor to remove some repeated lines in CBlockIndex constructors.

@BitcoinPullTester
Copy link

BitcoinPullTester commented Jul 2, 2014

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4457_834e46e847188df513b8b57ab30fe9940f2b2dd0/ for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@laanwj
Copy link
Member

laanwj commented Jul 4, 2014

Untested ACK

@laanwj
Copy link
Member

laanwj commented Jul 7, 2014

Ran this on my nodes on the weekend. No issues. Code changes look obviously correct.

@laanwj laanwj merged commit 834e46e into bitcoin:master Jul 7, 2014
laanwj added a commit that referenced this pull request Jul 7, 2014
@laanwj
Merge pull request #4457
4ed2315 
834e46e CBlockIndex()::SetNull() method to avoid code repetition (jtimon)
@jtimon jtimon deleted the dry branch July 7, 2014 07:57
@jtimon jtimon mentioned this pull request Aug 30, 2014
Closed
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtimon @BitcoinPullTester @laanwj