Skip to content

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Jun 30, 2014

int64_t is preferred over unsigned int for time calculations when possible.

@sipa
Copy link
Member

sipa commented Jun 30, 2014

Untested ACK

@laanwj
Copy link
Member

laanwj commented Jul 1, 2014

I've reviewed the code and found no problems. Nice to get rid of a cast here and there in the RPC code.

@jgarzik
Copy link
Contributor

jgarzik commented Jul 1, 2014

untested ACK

@BitcoinPullTester
Copy link

Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/p4446_56d53b2a920f40caacc40d0bf45396c68584c526/ for binaries and test log.

This could happen for one of several reasons:

  1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
  2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
  3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
  4. The test suite fails on either Linux i386 or Win32
  5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@laanwj
Copy link
Member

laanwj commented Jul 7, 2014

Tested ACK

@laanwj laanwj merged commit 209377a into bitcoin:master Jul 7, 2014
laanwj added a commit that referenced this pull request Jul 7, 2014
209377a Use GetBlockTime() more (jtimon)
@jtimon jtimon deleted the int64time branch July 7, 2014 08:34
@jtimon jtimon mentioned this pull request Aug 30, 2014
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants