Check for duplicate txins in CheckTransaction. #443
Conversation
|
CheckBlock calls this function. Won't this cause a fork in the blockchain if the network doesn't upgrade as a whole and a transaction that runs afoul of this check is included in a block? |
|
Such a transaction should already cause the block it is included in to be invalid, as ConnectInputs will detect the duplicate use of the same prevout. This patch just causes such cases to be detected in an earlier stage, before it enters the memory pool. |
|
If a transaction with a duplicate input is in a block, the chain should be forked (or people are making money out of nothing). |
|
Right, looks like the vSpent check in ConnectInputs takes care of it. |
Check for duplicate txins in CheckTransaction.
…iant characters b262ee2 Sanitize RPC responses and replace non-UTF-8 compliant characters (dexX7)
Add start-up functionality to check if Qt application settings need to be migrated.
…nt/non-inflation chains 7bac720 add block subsidy argument to allow different/non-inflation chains (Gregory Sanders) Pull request description: Previously we just set this to 0 and continued, this allows tests to otherwise pass up until this point. Tree-SHA512: e4e6ae85779a6079ccad38941b4b0dbb3362fa4d902aff5cedbea4641201646f6946cc0d140cb0fdac81c5009ff983baabebcbeeed99f089e44ad492fd6cd1ee
Introduction - Trust Model of Bitcoin
4 participants
These should be invalid.