-
Notifications
You must be signed in to change notification settings - Fork 38.7k
Reduce bignum.h now it is only needed for scriptnum_tests #4160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
perhaps also move it to the test directory? |
|
See #4159 |
|
Well you also slimmed bignum.h down, so let's go with this one. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7cd0af7cc222d0694ce72e71458aef460698ee2c for binaries and test log. |
|
Alternatively, we could replace the scriptnum tests by data-driven ones, and get rid of bignum.h entirely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of CADDR_TIME_VERSION. It was indirectly included through bignum.h.
|
Having bignum in the tests directory is fine for now. At some point we could move to data-driven tests, but it seems low-priority as long as we need OpenSSL for other things. |
No description provided.