Remove build-time no-IPv6 setting #4115
Conversation
The year is 2014. All supported operating systems have IPv6 support, most certainly at build time (this doesn't mean that IPv6 is configured, of course). If noone is exercising the functionality to disable it, that means it doesn't get tested, and IMO it's better to get rid of it. (it's also not used consistently in RPC/boost and Net code...)
|
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/e27c4110d9c47d30fed4b940813c9c8b82a97fbd for binaries and test log. This could happen for one of several reasons:
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ |
|
ACK idea & code. |
|
untested ACK |
|
Sounds like a good idea. |
|
I checked that the bitcoind binary stays the same with and without this patch, apart from line numbers passed to assert_fail() and the git tag. |
e27c411 Remove build-time no-IPv6 setting (Wladimir J. van der Laan)
5 participants
The year is 2014. All supported operating systems have IPv6 support, most certainly at build time (this doesn't mean that IPv6 is configured, of course).
If noone is exercising the functionality to disable it, that means it doesn't get tested, and IMO it's better to get rid of it.
(it's also not used consistently in RPC/boost and Net code: if USE_IPV6 is not enabled, it is still assumed that boost is compiled with ipv6 support, so this would never work...)