Skip to content

Conversation

@cozz
Copy link
Contributor

@cozz cozz commented Apr 25, 2014

Adds the possibility to open a transaction in block explorer through right-click context menu in transactions tab.

Can also be setup on testnet, as testnet uses a different qt-settings file.
To make the implementation simple, changing the option needs client restart to take effect.

@laanwj
Copy link
Member

laanwj commented Apr 25, 2014

Looks ok to me.

Nit: please add a menu seperator between the 'normal' actions and the 'third party' actions.

@cozz
Copy link
Contributor Author

cozz commented Apr 25, 2014

I already added the menu separator, but after I made the screenshot.

@laanwj laanwj added this to the 0.9.2 milestone Apr 25, 2014
@christophebiocca
Copy link

I had some comments on your original pull, but I think they got lost when you refreshed it. I'll leave them here:

  • Splitting a string on ;http seems really ugly. Can you use | as a separator (it's never valid in a url), or even better make the string a list?
  • your logic to title case the domain name is going to look weird for live.insight.is. I'd just leave it verbatim.

@cozz
Copy link
Contributor Author

cozz commented Apr 25, 2014

update:

thirdpartyurls4

    https://blockchain.info/tx/%s|https://blockexplorer.com/tx/%s|http://luckyb.it/browse?search=%s

thirdpartyurls5

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/40c5b939f2bff960e397da6ae3651952adc68cbe for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@laanwj
Copy link
Member

laanwj commented May 1, 2014

ACK

@laanwj laanwj merged commit 40c5b93 into bitcoin:master May 1, 2014
laanwj added a commit that referenced this pull request May 1, 2014
40c5b93 [Qt] Optionally add third party links to transaction context menu (Cozz Lovan)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants