Make mining fee policy match relay fee policy. #3838
Conversation
This resolves a case in which a mismatch could be used to bloat up the mempool by sending transactions that pay enough fee to relay, but not to be mined, with the default policies.
|
ACK, but lets not forget to mention this in the release notes. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/037b4f1485404a69f96ac6c448a97d21315c8663 for binaries and test log. |
|
Shouldn't this PR apply to |
|
We have a policy of only pulling in changes in side branches that have been merged into master, just to make reasoning easier of what is where. This means that pull requests should always be for master (well, perhaps except for readme/release notes specific to a release). |
|
Correct. Default is "upstream first" (==master), then backport. This helps ensure bug fixes are not lost. |
|
Would be nice to move nMinTxFee constant to wallet.cpp/h at some point, as it now only affects the wallet. After this commit there is only one use of nMinTxFee remaining outside wallet.cpp and the options parsing, in GetMinFee ( https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L781 ). |
|
Merged into master and 0.9.0 (and doc/release-notes.md in the 0.9.0 branch updated). |
Only the minimum relay fee was intended to be reduced to 1000 satoshis, but due to mempool bugs, nodes can't handle divergent relay and mining fee rates properly yet. A quick workaround was merged for 0.9 by using the relay fee for mining (PR bitcoin#3838), but without any consensus for the actual mining default to be dropped. Unfortunately, many miners seem to still run with default policies, and this fee rate makes spamming too cheap still. This brings the minimum fee rate back to up 10000 satoshis, which reflects the last consensus for standard mining fee rate.
Only the minimum relay fee was intended to be reduced to 1000 satoshis, but due to mempool bugs, nodes can't handle divergent relay and mining fee rates properly yet. A quick workaround was merged for 0.9 by using the relay fee for mining (PR bitcoin#3838), but without any consensus for the actual mining default to be dropped. Unfortunately, many miners seem to still run with default policies, and this fee rate makes spamming too cheap still. This brings the minimum fee rate back to up 10000 satoshis, which reflects the last consensus for standard mining fee rate.
Only the minimum relay fee was intended to be reduced to 1000 satoshis, but due to mempool bugs, nodes can't handle divergent relay and mining fee rates properly yet. A quick workaround was merged for 0.9 by using the relay fee for mining (PR bitcoin#3838), but without any consensus for the actual mining default to be dropped. Unfortunately, many miners seem to still run with default policies, and this fee rate makes spamming too cheap still. This brings the minimum fee rate back to up 10000 satoshis, which reflects the last consensus for standard mining fee rate.
Only the minimum relay fee was intended to be reduced to 1000 satoshis, but due to mempool bugs, nodes can't handle divergent relay and mining fee rates properly yet. A quick workaround was merged for 0.9 by using the relay fee for mining (PR bitcoin#3838), but without any consensus for the actual mining default to be dropped. Unfortunately, many miners seem to still run with default policies, and this fee rate makes spamming too cheap still. This brings the minimum fee rate back to up 10000 satoshis, which reflects the last consensus for standard mining fee rate.
6 participants
This resolves a case in which a mismatch could be used to bloat up the mempool by sending transactions that pay enough fee to relay, but not to be mined, with the default policies.