Skip to content

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Mar 8, 2014

Prerequisite for #3824

@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/89ec3a29111075ff1eb8309d6a43662c492c30af for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@laanwj
Copy link
Member

laanwj commented Mar 8, 2014

ACK, it makes sense to base the choice on the network ID directly.
This also means that future added chains will be shown as testnet, which is much more likely than a new mainnet.

@laanwj laanwj added this to the 0.10.0 milestone Mar 8, 2014
laanwj added a commit that referenced this pull request Mar 10, 2014
89ec3a2 MainNet is the special case for the GUI (jtimon)
@laanwj laanwj merged commit 89ec3a2 into bitcoin:master Mar 10, 2014
@jtimon jtimon deleted the mainnetgui branch June 18, 2014 18:20
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants