Skip to content

Avoid using CBigNum for simple multiplications #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sipa wants to merge 1 commit into from
Closed

Avoid using CBigNum for simple multiplications #3517

sipa wants to merge 1 commit into from

Conversation

@sipa
Copy link
Member

@sipa sipa commented Jan 11, 2014

Implement a simple multiplication operator in uint256, and use it for the few cases where we used to convert to CBigNum for this.

Tests are included that verify the behavior is identical to converting to CBigNum, doing the multiplication, and converting back.

Overall goal: reduce dependency on OpenSSL where possible in core code.

@BitcoinPullTester
Copy link

BitcoinPullTester commented Jan 12, 2014

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/87aacaa633bfedaf9947e051dee47807bdeaff9b for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@laanwj
Copy link
Member

laanwj commented Jan 12, 2014

ACK

@sipa sipa mentioned this pull request Jan 18, 2014
Merged
@sipa
Copy link
Member Author

sipa commented Apr 21, 2014

I completely forgot I wrote this.

It's superceded by #4076 now.

@sipa sipa closed this Apr 21, 2014
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sipa @BitcoinPullTester @laanwj