Skip to content

guix: Fix osslsigncode tests #34227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 1 commit into from
Jan 9, 2026
Merged

guix: Fix osslsigncode tests #34227

fanquake merged 1 commit into from
Jan 9, 2026
+12 −1

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Jan 8, 2026

This PR aims to improve the experience for Guix builders when creating new Guix profiles after 2025. In particular, it should be helpful for those who are new to building with Guix.

Fixes #34220.

Other possible alternatives to consider include:

  1. Applying a workaround as suggested here.

  2. Updating the package as suggested here.

  3. Disabling tests as suggested here.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 8, 2026 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34227.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK janb84, fanquake
Concept ACK danielabrozzoni

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

@hebasto hebasto mentioned this pull request Jan 8, 2026
Closed
1 task
@hebasto
Copy link
Member Author

hebasto commented Jan 8, 2026 •
edited
Loading

My partial Guix build:

$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
x86_64
4d085ae08025ab7d34947c9a0fdf245ed2b6b5dcd489c5154641954fdcfb4566  guix-build-55c9c35b65e3/output/dist-archive/bitcoin-55c9c35b65e3.tar.gz
e5b220ac5fb4b25efa8b4f288538857a81b54a637a6994d9b203da876a6d1f37  guix-build-55c9c35b65e3/output/x86_64-w64-mingw32/SHA256SUMS.part
e38779e4cda3a41cd1f2e74e4de3e0133a8e8e04f488c1e765e96fb8916eee3b  guix-build-55c9c35b65e3/output/x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-codesigning.tar.gz
b0f4780199eaf106fe7b841ebdcdcc42f17be7a850420227ad40878fbb392797  guix-build-55c9c35b65e3/output/x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-debug.zip
f0b3c45ccb7ae101957351cbd0669a7d3d0ec8955a07da5e458d7db78b814eb5  guix-build-55c9c35b65e3/output/x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-setup-unsigned.exe
56d859f2a9971fac33f8d9b4c6da57114c919de0f3bd759bf7e0feea9d34d393  guix-build-55c9c35b65e3/output/x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-unsigned.zip

@psgreco
Copy link
Contributor

psgreco commented Jan 8, 2026

Profile created correctly and partial guix build matches

4d085ae08025ab7d34947c9a0fdf245ed2b6b5dcd489c5154641954fdcfb4566  guix-build-55c9c35b65e3/output/dist-archive/bitcoin-55c9c35b65e3.tar.gz
e5b220ac5fb4b25efa8b4f288538857a81b54a637a6994d9b203da876a6d1f37  guix-build-55c9c35b65e3/output/x86_64-w64-mingw32/SHA256SUMS.part
e38779e4cda3a41cd1f2e74e4de3e0133a8e8e04f488c1e765e96fb8916eee3b  guix-build-55c9c35b65e3/output/x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-codesigning.tar.gz
b0f4780199eaf106fe7b841ebdcdcc42f17be7a850420227ad40878fbb392797  guix-build-55c9c35b65e3/output/x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-debug.zip
f0b3c45ccb7ae101957351cbd0669a7d3d0ec8955a07da5e458d7db78b814eb5  guix-build-55c9c35b65e3/output/x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-setup-unsigned.exe
56d859f2a9971fac33f8d9b4c6da57114c919de0f3bd759bf7e0feea9d34d393  guix-build-55c9c35b65e3/output/x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-unsigned.zip

danielabrozzoni
danielabrozzoni reviewed Jan 8, 2026
View reviewed changes
Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, thanks for this! I was unable to build v30.2rc1 due to the same error reported in #34220, but this branch builds successfully for me.

I am very unfamiliar with guix and the build system, so i can't code review, unfortunately.

My build checksum:

> sha256sum dist-archive/*.tar.gz
sha256sum x86_64-w64-mingw32/SHA256SUMS.part
sha256sum x86_64-w64-mingw32/*.tar.gz
sha256sum x86_64-w64-mingw32/*.zip
sha256sum x86_64-w64-mingw32/*.exe

4d085ae08025ab7d34947c9a0fdf245ed2b6b5dcd489c5154641954fdcfb4566  dist-archive/bitcoin-55c9c35b65e3.tar.gz
e5b220ac5fb4b25efa8b4f288538857a81b54a637a6994d9b203da876a6d1f37  x86_64-w64-mingw32/SHA256SUMS.part
e38779e4cda3a41cd1f2e74e4de3e0133a8e8e04f488c1e765e96fb8916eee3b  x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-codesigning.tar.gz
b0f4780199eaf106fe7b841ebdcdcc42f17be7a850420227ad40878fbb392797  x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-debug.zip
56d859f2a9971fac33f8d9b4c6da57114c919de0f3bd759bf7e0feea9d34d393  x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-unsigned.zip
f0b3c45ccb7ae101957351cbd0669a7d3d0ec8955a07da5e458d7db78b814eb5  x86_64-w64-mingw32/bitcoin-55c9c35b65e3-win64-setup-unsigned.exe

maflcko
maflcko reviewed Jan 8, 2026
View reviewed changes
@fanquake
Copy link
Member

fanquake commented Jan 8, 2026

Not sure about the approach, given it's going to make any future package updates much more complicated, and doesn't fully fix the issue (just makes it occur later).

@hebasto
Copy link
Member Author

hebasto commented Jan 8, 2026

Not sure about the approach, given it's going to make any future package updates much more complicated, and doesn't fully fix the issue (just makes it occur later).

I consider this fix as a temporarily mitigation. I assume that other options, such as updating or replacing the package, will be evaluated over the next 5 years, and that this patch could then be discarded.

@fanquake
Copy link
Member

fanquake commented Jan 8, 2026

Also, was this reported upstream, so it can be fixed, if it hasn't been already (and if it has, can we just take that patch)?

@hebasto
Copy link
Member Author

hebasto commented Jan 8, 2026 •
edited
Loading

Also, was this reported upstream, so it can be fixed, if it hasn't been already (and if it has, can we just take that patch)?

Not yet. The upstream project does not maintain version branches, and I haven't evaluated the current master branch yet.

UPDATE. It even fails to compile on my system due to a syntax (!) error.

@psgreco
Copy link
Contributor

psgreco commented Jan 8, 2026

Current release (2.10) has changed completely the way the certs are generated. I tried to update the manifest.scm to use 2.10, but it requires an extra dependency to build, zlib IIRC so it looked like a bigger change and didn't wanna mess with it

@hebasto hebasto force-pushed the 260108-guix-osslsigncode branch from 55c9c35 to 194114d Compare January 8, 2026 12:46
@hebasto
Copy link
Member Author

hebasto commented Jan 8, 2026

The feedback from @maflcko has been addressed.

@psgreco
Copy link
Contributor

psgreco commented Jan 8, 2026 

6c15853ed61a18b993443f25401a2b3418177652ce0110edc57389709363abf8  guix-build-194114daf385/output/dist-archive/bitcoin-194114daf385.tar.gz
bdc487aa76acc262e18cbc3fc9768c0b703fcf3713513d08ba560889db006e5c  guix-build-194114daf385/output/x86_64-w64-mingw32/SHA256SUMS.part
f40f77736a5634dc1efce929d1ebdd702a89b1f15f1f12709af2f6cf0ea6373d  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-codesigning.tar.gz
be623ed97291551ff3372ff19bb1cc74b0e9694d969bfb73919842ff85e036e9  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-debug.zip
3734b69bc7f83a12ab68585a84b748dfc3cab1d861d8f506922b5ff7d7e9a8da  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-setup-unsigned.exe
38c148cedb37fe6f7fc24e4d0d0651c6c0445ed48c99b7a7e1edcf2e5efdf3c3  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-unsigned.zip

@hebasto
Copy link
Member Author

hebasto commented Jan 8, 2026

My partial Guix build:

$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
aarch64
6c15853ed61a18b993443f25401a2b3418177652ce0110edc57389709363abf8  guix-build-194114daf385/output/dist-archive/bitcoin-194114daf385.tar.gz
bdc487aa76acc262e18cbc3fc9768c0b703fcf3713513d08ba560889db006e5c  guix-build-194114daf385/output/x86_64-w64-mingw32/SHA256SUMS.part
f40f77736a5634dc1efce929d1ebdd702a89b1f15f1f12709af2f6cf0ea6373d  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-codesigning.tar.gz
be623ed97291551ff3372ff19bb1cc74b0e9694d969bfb73919842ff85e036e9  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-debug.zip
3734b69bc7f83a12ab68585a84b748dfc3cab1d861d8f506922b5ff7d7e9a8da  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-setup-unsigned.exe
38c148cedb37fe6f7fc24e4d0d0651c6c0445ed48c99b7a7e1edcf2e5efdf3c3  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-unsigned.zip

janb84
janb84 reviewed Jan 8, 2026
View reviewed changes
Copy link
Contributor

@janb84 janb84 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 194114d

Simple temporary solution to fake the time for one package where it's certificates are expired.

Given all the alternatives, this seems like the best solution for now, until upstream is patched / other version is ready for use.

Edit: is the PR description still correct ?

my Guix Build Output

Host architecture: aarch64
Commit: 194114daf385

89ac809be13e442df676a1e7fc88b75307756fdd208e271117e9b6899d97a3da  guix-build-194114daf385/output/aarch64-linux-gnu/SHA256SUMS.part
c3322b9fe8f0f4fe4b20d328207c5db490db499d452e1f97241dc267410746cf  guix-build-194114daf385/output/aarch64-linux-gnu/bitcoin-194114daf385-aarch64-linux-gnu-debug.tar.gz
9f9ca36622e86c7ebb9d1999a5aad529cce99c0266c0929c6cb059e2acfe35da  guix-build-194114daf385/output/aarch64-linux-gnu/bitcoin-194114daf385-aarch64-linux-gnu.tar.gz
228a1740c214bd94bb307a6a7ae7b89ff2c5be7b378126cd96a1ccde0a9a08fc  guix-build-194114daf385/output/arm-linux-gnueabihf/SHA256SUMS.part
f0f8a374ae54a8877dd7e5a8b7fa0796bf13e0694a20b7f305d3815b7fbb03ce  guix-build-194114daf385/output/arm-linux-gnueabihf/bitcoin-194114daf385-arm-linux-gnueabihf-debug.tar.gz
d0568db306f2cd2d56ecc9ac4d104e38c15cc254fc2c0c5de77720516045cf3d  guix-build-194114daf385/output/arm-linux-gnueabihf/bitcoin-194114daf385-arm-linux-gnueabihf.tar.gz
e291c15edcd5312aa482ea108a48e4a0b5993440a9ad2f680568240080572154  guix-build-194114daf385/output/arm64-apple-darwin/SHA256SUMS.part
ebd1aad46a0c7cbc133cd857ae8c6b652f1c665ba9680c3370b28f43b026c692  guix-build-194114daf385/output/arm64-apple-darwin/bitcoin-194114daf385-arm64-apple-darwin-codesigning.tar.gz
421245463534af51444e270f3a6f92ee754aa9fba920585f124dad2bdba5e526  guix-build-194114daf385/output/arm64-apple-darwin/bitcoin-194114daf385-arm64-apple-darwin-unsigned.tar.gz
6c2abba20837fd5c1ccfb12dbb72c561b6dc80d9ff611d2be45137bc3f27de18  guix-build-194114daf385/output/arm64-apple-darwin/bitcoin-194114daf385-arm64-apple-darwin-unsigned.zip
6c15853ed61a18b993443f25401a2b3418177652ce0110edc57389709363abf8  guix-build-194114daf385/output/dist-archive/bitcoin-194114daf385.tar.gz
a759c23990e3bbaeb11c955c4f5441777cbb053e68f91e60e341042c4a64e8f0  guix-build-194114daf385/output/powerpc64-linux-gnu/SHA256SUMS.part
a0b2190f985f6549e9dd3fbd009fb694815bb1975d63e704da6836f2f990dcd1  guix-build-194114daf385/output/powerpc64-linux-gnu/bitcoin-194114daf385-powerpc64-linux-gnu-debug.tar.gz
7e907a068e2bd2c4f4bde86f6b9b01ce8d0de6b70df126e9d4ecc0ad7a2d8576  guix-build-194114daf385/output/powerpc64-linux-gnu/bitcoin-194114daf385-powerpc64-linux-gnu.tar.gz
fa2f30524890e939e9046003422c3c39dee680c4d15e0b8b47905a040197e3e6  guix-build-194114daf385/output/riscv64-linux-gnu/SHA256SUMS.part
ef330ee1703549d50df39af872c7ea6cafe5a43c0ccb068da18a3504b10740db  guix-build-194114daf385/output/riscv64-linux-gnu/bitcoin-194114daf385-riscv64-linux-gnu-debug.tar.gz
1c094f1297cf1a2aa9da798e69a28b3cd15aa7588567f598af782022dde139e9  guix-build-194114daf385/output/riscv64-linux-gnu/bitcoin-194114daf385-riscv64-linux-gnu.tar.gz
10d4063e11acc45ebce88229c680a8cf40367c299acd24448e66a29e94738e57  guix-build-194114daf385/output/x86_64-apple-darwin/SHA256SUMS.part
a9892d8e7234e22203e595ede1bae78df5a5979730ffd9adb9e431be9345efe6  guix-build-194114daf385/output/x86_64-apple-darwin/bitcoin-194114daf385-x86_64-apple-darwin-codesigning.tar.gz
ed8f5bc3b6a3e07ccd48879482eeec05a85be2ed70fe44f80728d310c25cfc1c  guix-build-194114daf385/output/x86_64-apple-darwin/bitcoin-194114daf385-x86_64-apple-darwin-unsigned.tar.gz
e71cf6637a482b02eafd5b866ed1d99e0e10c345cf97c2080191b43846156a52  guix-build-194114daf385/output/x86_64-apple-darwin/bitcoin-194114daf385-x86_64-apple-darwin-unsigned.zip
50686adb8d106a3d8896c09e84a35d329dfe14e4805877e7dd523618a9ca9bab  guix-build-194114daf385/output/x86_64-linux-gnu/SHA256SUMS.part
2410bc01c7382ad3f04632f4c8acbb6e90279248bb02951092ce962c88254f77  guix-build-194114daf385/output/x86_64-linux-gnu/bitcoin-194114daf385-x86_64-linux-gnu-debug.tar.gz
7d75c6b30deeb2ec7fb71338b9778ee53a0d202e21cbbc674ca9584c4e8b9b1a  guix-build-194114daf385/output/x86_64-linux-gnu/bitcoin-194114daf385-x86_64-linux-gnu.tar.gz
bdc487aa76acc262e18cbc3fc9768c0b703fcf3713513d08ba560889db006e5c  guix-build-194114daf385/output/x86_64-w64-mingw32/SHA256SUMS.part
f40f77736a5634dc1efce929d1ebdd702a89b1f15f1f12709af2f6cf0ea6373d  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-codesigning.tar.gz
be623ed97291551ff3372ff19bb1cc74b0e9694d969bfb73919842ff85e036e9  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-debug.zip
3734b69bc7f83a12ab68585a84b748dfc3cab1d861d8f506922b5ff7d7e9a8da  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-setup-unsigned.exe
38c148cedb37fe6f7fc24e4d0d0651c6c0445ed48c99b7a7e1edcf2e5efdf3c3  guix-build-194114daf385/output/x86_64-w64-mingw32/bitcoin-194114daf385-win64-unsigned.zip

@hebasto
Copy link
Member Author

hebasto commented Jan 8, 2026

Edit: is the PR description still correct ?

Which part are you referring to?

@janb84
Copy link
Contributor

janb84 commented Jan 8, 2026

Edit: is the PR description still correct ?

Which part are you referring to?

This Part (especially the last part.?)

"This PR aims to improve the experience for Guix builders when creating new Guix profiles after 2025. In particular, it should be helpful for those who are new to building with Guix."

Given the new (temporary) time faking solution, wouldn't something like this be more descriptive?

"This PR aims to improve the experience for Guix builders when creating new Guix profiles after 2025. Before this PR, creating a new Guix profile fails because of expired certificates. This PR provides a fix until an upstream permanent solution is provided.

Fixes [...] << rest of pr description >> "

@fanquake
Copy link
Member

fanquake commented Jan 9, 2026

ACK 194114d as a short-term, backportable workaround.

@fanquake fanquake merged commit 2d87afc into bitcoin:master Jan 9, 2026
27 checks passed
@hebasto hebasto deleted the 260108-guix-osslsigncode branch January 9, 2026 11:13
@fanquake fanquake mentioned this pull request Jan 9, 2026
Merged
@fanquake
Copy link
Member

fanquake commented Jan 9, 2026

Backported to 30.x in #34229.

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 9, 2026
@hebasto @fanquake
guix: Fix osslsigncode tests
6d86b32 
Github-Pull: bitcoin#34227
Rebased-From: 194114d
fanquake added a commit that referenced this pull request Jan 9, 2026
@fanquake
Merge #34229: [30.2] Backports & Final
4d7d5f6 
04a996b doc: update manual pages for v30.2 (fanquake)
ed355b8 build: bump version to v30.2 (fanquake)
6c98d68 doc: update release notes for v30.2 (fanquake)
6d86b32 guix: Fix `osslsigncode` tests (Hennadii Stepanov)
1dae002 wallet: test: Failed migration cleanup (David Gumberg)
9e59047 test: migration, avoid backup name mismatch in default_wallet_failure (furszy)

Pull request description:

  Backports:
  * #34221
  * #34226
  * #34227

ACKs for top commit:
  hebasto:
    ACK 04a996b, I have reviewed the code and it looks OK.
  willcl-ark:
    ACK 04a996b
  marcofleon:
    ACK 04a996b

Tree-SHA512: 3389b9b629dcb920186b383353fd386bb757967d224e0267501b5e2083dc1e6cba051df6ef646de05c0e58fd43c9f549b9175eefb77fed1fe9ab7d1648b2d9e7
@fanquake fanquake mentioned this pull request Jan 9, 2026
Closed
glozow pushed a commit to glozow/bitcoin that referenced this pull request Jan 12, 2026
@hebasto @glozow
guix: Fix osslsigncode tests
daef585 
Github-Pull: bitcoin#34227
Rebased-From: 194114d
@glozow glozow mentioned this pull request Jan 12, 2026
Open
@fanquake
Copy link
Member

fanquake commented Jan 13, 2026

Backported to 29.x in #34268.

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 13, 2026
@hebasto @fanquake
guix: Fix osslsigncode tests
3dd011e 
Github-Pull: bitcoin#34227
Rebased-From: 194114d
@fanquake fanquake mentioned this pull request Jan 13, 2026
Open
@fanquake
Copy link
Member

fanquake commented Jan 13, 2026

Backported to 28.x in #34270.

@glozow
Copy link
Member

glozow commented Jan 13, 2026

Backport to 29.x in #34268

kwvg added a commit to dashpay/dash that referenced this pull request Jan 13, 2026
@kwvg
merge bitcoin#34227: Fix osslsigncode tests
b10993e
kwvg added a commit to kwvg/dash that referenced this pull request Jan 13, 2026
@kwvg
merge bitcoin#34227: Fix osslsigncode tests
8f1cf15
@coderabbitai coderabbitai bot mentioned this pull request Jan 14, 2026
Open
5 tasks
kwvg added a commit to kwvg/dash that referenced this pull request Jan 14, 2026
@kwvg
merge bitcoin#34227: Fix osslsigncode tests
a4ed8f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielabrozzoni danielabrozzoni Awaiting requested review from danielabrozzoni

2 more reviewers

@janb84 janb84 janb84 left review comments

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Guix builds fail after 2026

8 participants

@hebasto @DrahtBot @psgreco @fanquake @janb84 @glozow @maflcko @danielabrozzoni