wallet: fix ancient wallets migration #34198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34198. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste ConflictsNo conflicts as of last run. LLM Linter (✨ experimental)Possible places where comparison-specific test macros should replace generic comparisons:
2026-01-07 |
Contributor
The best block locator was introduced in bitcoin#152, previously created wallets do not have these record.
Pre-bitcoin#152 wallets have no best block stored. Test we can migrate them.
furszy
force-pushed
the
2026_wallet_migration_ancient_wallets
branch
from
63a079e to
785eadf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently fail migration if the wallet does not contain the best block locator.
This is a problem for wallets created before #152, which are not storing such record.
Missing this record is not an error. it simply means the wallet will scan the chain prior
to finish migration.
Note:
Originally I wrote the test using a BDB library (
bsddb3) but I wasn't happy with thenew dependency, and ended up zeroing the record length manually. I'm not sure this
will work on every platform. If it doesn't, we can just just drop the test as this can be
tested manually on any ancient wallet too.